Make pro-active breakpoints opt-in

Author: lionel-

crates/ark/src/console/console_repl.rs

@@ -35,7 +35,7 @@ const DEBUG_COMMANDS_CONTINUE: &[&str] = &["n", "f", "c", "cont", "Q"];
 static R_INIT: once_cell::sync::OnceCell<()> = once_cell::sync::OnceCell::new();
 
 /// An enum representing the different modes in which the R session can run.
-#[derive(PartialEq, Clone, Copy)]
+#[derive(Debug, PartialEq, Clone, Copy)]
 pub enum SessionMode {
     /// A session with an interactive console (REPL), such as in Positron.
     Console,
@@ -192,6 +192,7 @@ pub(crate) struct KernelInfo {
     pub(crate) banner: String,
     pub(crate) input_prompt: Option<String>,
     pub(crate) continuation_prompt: Option<String>,
+    pub(crate) session_mode: SessionMode,
 }
 
 /// The kind of prompt we're handling in the REPL.
@@ -485,7 +486,7 @@ impl Console {
         log::info!(
             "R has started and ark handlers have been registered, completing initialization."
         );
-        Self::complete_initialization(console.banner.take(), kernel_init_tx);
+        Self::complete_initialization(console.banner.take(), console.session_mode, kernel_init_tx);
 
         // Spawn handler loop for async messages from other components (e.g., LSP).
         // Note that we do it after init is complete to avoid deadlocking
@@ -576,7 +577,11 @@ impl Console {
     /// # Safety
     ///
     /// Can only be called from the R thread, and only once.
-    fn complete_initialization(banner: Option<String>, mut kernel_init_tx: Bus<KernelInfo>) {
+    fn complete_initialization(
+        banner: Option<String>,
+        session_mode: SessionMode,
+        mut kernel_init_tx: Bus<KernelInfo>,
+    ) {
         let version = unsafe {
             let version = Rf_findVarInFrame(R_BaseNamespace, r_symbol!("R.version.string"));
             RObject::new(version).to::<String>().unwrap()
@@ -591,6 +596,7 @@ impl Console {
             banner: banner.unwrap_or_default(),
             input_prompt: Some(input_prompt),
             continuation_prompt: Some(continuation_prompt),
+            session_mode,
         };
 
         // Set `R_INIT` before broadcasting so that threads unblocked by the

crates/ark/src/shell.rs

@@ -45,6 +45,7 @@ use tokio::sync::mpsc::UnboundedSender as AsyncUnboundedSender;
 use crate::ark_comm::ArkComm;
 use crate::console::Console;
 use crate::console::KernelInfo;
+use crate::console::SessionMode;
 use crate::data_explorer::r_data_explorer::DATA_EXPLORER_COMM_NAME;
 use crate::help::r_help::RHelp;
 use crate::help_proxy;
@@ -144,6 +145,11 @@ impl ShellHandler for Shell {
                 continuation_prompt: kernel_info.continuation_prompt.clone(),
             }),
         };
+        let mut supported_features = vec![String::from("debugger")];
+        if matches!(kernel_info.session_mode, SessionMode::Notebook) {
+            supported_features.push(String::from("proactive breakpoints"));
+        }
+
         Ok(KernelInfoReply {
             status: Status::Ok,
             banner: kernel_info.banner.clone(),
@@ -152,7 +158,7 @@ impl ShellHandler for Shell {
             language_info: info,
             implementation: String::from("ark"),
             implementation_version: String::from(env!("CARGO_PKG_VERSION")),
-            supported_features: vec![String::from("debugger")],
+            supported_features,
         })
     }