ci: add release comment if extension is changed but manifest not upgraded (#342)

* Refactor pr-release-comment to use release-check artifacts

Instead of duplicating version comparison logic, the pr-release-comment
job now reads release-check-*.json artifacts emitted by release-extension.
This keeps the version logic in one place.

Changes:
- release-extension action now writes release-check JSON inline at each
  decision point (will release / holding back / 0.0.0)
- pr-release-comment depends on release jobs instead of change-detection
  jobs, and aggregates the artifacts with jq

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* make comment more accurate

* test: trigger reaper extension without version bump

* fix: rename artifact to would-release to avoid collision with release-*.json pattern

* change landing page instead of reaper

* CI test: change second app without updating manifest

* refactor: simplify release-check pipeline and summarize will-release (#343)

- Consolidate the should_release step in the release-extension action:
  single message/output/JSON emission instead of a 3-branch helper, and
  use jq -n for safer JSON construction.
- Gate release-check artifact upload at the action level (PRs, non-0.0.0),
  dropping the filter that used to live downstream.
- Merge the aggregate + comment workflow steps into one; no intermediate
  no_release.json, no duplicate empty-check.
- Expand the PR comment to summarize both will-release and won't-release
  extensions so contributors can confirm what will release on merge.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* revert README test changes

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Jordan Jensen <jordan.jensen@posit.co>

Author: 3 people

.github/actions/release-extension/action.yml

@@ -38,18 +38,17 @@ runs:
     # We compare that here, and echo if a release will occur
     # This can be helpful when looking at Pull Request action outputs
     # so it is clear what will happen on a merge to `main`
+    # Also writes release-check JSON for PR comment aggregation
     - name: Check if manifest has newer version
       id: should_release
       run: |
         # Add the extension name to the summary header for clarity
         echo "# Extension: ${{ inputs.extension-name }}" >> $GITHUB_STEP_SUMMARY
         echo "" >> $GITHUB_STEP_SUMMARY
-        
+
         if [ "$MANIFEST_VERSION" = "0.0.0" ]; then
           MESSAGE="⚠️ Version 0.0.0 is reserved and will never be released."
-          echo "$MESSAGE"
-          echo "$MESSAGE" >> $GITHUB_STEP_SUMMARY
-          echo "should_release=false" >> "$GITHUB_OUTPUT"
+          SHOULD_RELEASE=false
         else
           # Normal version comparison logic
           VERSION_INFO="The manifest version is '$MANIFEST_VERSION' and the released version is '$LATEST_VERSION'"
@@ -60,16 +59,24 @@ runs:
           HIGHER_VERSION=$(semver "$MANIFEST_VERSION" "$LATEST_VERSION" | tail -n 1)
           if [ "$MANIFEST_VERSION" = "$HIGHER_VERSION" ] && [ "$MANIFEST_VERSION" != "$LATEST_VERSION" ]; then
             MESSAGE="🚀 Will release! The manifest version is greater than the released version."
-            echo "$MESSAGE"
-            echo "$MESSAGE" >> $GITHUB_STEP_SUMMARY
-            echo "should_release=true" >> "$GITHUB_OUTPUT"
+            SHOULD_RELEASE=true
           else
             MESSAGE="😴 Holding back from release: The manifest version is not greater than the released version."
-            echo "$MESSAGE"
-            echo "$MESSAGE" >> $GITHUB_STEP_SUMMARY
-            echo "should_release=false" >> "$GITHUB_OUTPUT"
+            SHOULD_RELEASE=false
           fi
         fi
+
+        echo "$MESSAGE"
+        echo "$MESSAGE" >> $GITHUB_STEP_SUMMARY
+        echo "should_release=$SHOULD_RELEASE" >> "$GITHUB_OUTPUT"
+
+        jq -n \
+          --arg name "${{ inputs.extension-name }}" \
+          --arg manifest "$MANIFEST_VERSION" \
+          --arg latest "$LATEST_VERSION" \
+          --argjson would "$SHOULD_RELEASE" \
+          '{name: $name, manifestVersion: $manifest, latestVersion: $latest, wouldRelease: $would}' \
+          > would-release-${{ inputs.extension-name }}.json
       shell: bash
 
     # Here we download the packaged extension artifact to release
@@ -113,3 +120,13 @@ runs:
         name: release-${{ inputs.extension-name }}.json
         path: release-${{ inputs.extension-name }}.json
         retention-days: 1
+
+    # Upload on PRs for any non-reserved extension so the downstream comment
+    # job can summarize both will-release and won't-release extensions.
+    - name: Upload release check data
+      if: github.event_name == 'pull_request' && env.MANIFEST_VERSION != '0.0.0'
+      uses: actions/upload-artifact@v4
+      with:
+        name: would-release-${{ inputs.extension-name }}.json
+        path: would-release-${{ inputs.extension-name }}.json
+        retention-days: 1

.github/workflows/extensions.yml

@@ -248,6 +248,86 @@ jobs:
   # All extensions have been linted, packaged, and released, if necessary
   # Continuing to update the extension list with the latest release data
 
+  # Comments on PRs when extensions won't release (to help contributors notice they need to bump version)
+  pr-release-comment:
+    runs-on: ubuntu-latest
+    if: always() && github.event_name == 'pull_request'
+    needs: [
+      simple-extension-release,
+      publisher-command-center,
+      package-vulnerability-scanner,
+      runtime-version-scanner,
+      usage-metrics-dashboard,
+    ]
+    permissions:
+      pull-requests: write
+    env:
+      GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+    steps:
+      - name: Download release check artifacts
+        uses: actions/download-artifact@v4
+        with:
+          pattern: would-release-*.json
+          path: would-release
+          merge-multiple: true
+
+      - name: Post or update PR comment
+        run: |
+          # Artifacts are only uploaded by the release-extension action for
+          # extensions that changed (and aren't reserved 0.0.0), so an empty
+          # download directory means there's nothing to comment on.
+          if [ ! -d "would-release" ] || [ -z "$(ls -A would-release 2>/dev/null)" ]; then
+            echo "No extensions changed - no comment needed"
+            exit 0
+          fi
+
+          MARKER="<!-- release-check-comment -->"
+
+          WILL_RELEASE=$(jq -r 'select(.wouldRelease) | "- **\(.name)**: `\(.latestVersion)` → `\(.manifestVersion)`"' would-release/*.json)
+          WONT_RELEASE=$(jq -r 'select(.wouldRelease | not) | "- **\(.name)**: manifest version `\(.manifestVersion)` ≤ released version `\(.latestVersion)`"' would-release/*.json)
+
+          COMMENT_BODY="${MARKER}
+          ## Extension release summary
+          "
+
+          if [ -n "$WILL_RELEASE" ]; then
+            COMMENT_BODY+="
+          ### 🚀 Will release on merge
+
+          ${WILL_RELEASE}
+          "
+          fi
+
+          if [ -n "$WONT_RELEASE" ]; then
+            COMMENT_BODY+="
+          ### 😴 Changed but won't release
+
+          The following extensions have code changes but the manifest version hasn't been incremented:
+
+          ${WONT_RELEASE}
+
+          If you intended to release these changes, update the \`version\` field in each extension's \`manifest.json\`.
+          "
+          fi
+
+          COMMENT_BODY+="
+          See the [contributing guide](https://github.com/posit-dev/connect-extensions/blob/main/CONTRIBUTING.md#updating-content-in-the-connect-gallery) for details."
+
+          # Check for existing comment with marker
+          EXISTING_COMMENT_ID=$(gh api "repos/${{ github.repository }}/issues/${{ github.event.pull_request.number }}/comments" \
+            --jq ".[] | select(.body | contains(\"$MARKER\")) | .id" | head -1)
+
+          if [ -n "$EXISTING_COMMENT_ID" ]; then
+            echo "Updating existing comment (ID: $EXISTING_COMMENT_ID)..."
+            gh api "repos/${{ github.repository }}/issues/comments/$EXISTING_COMMENT_ID" \
+              -X PATCH \
+              -f body="$COMMENT_BODY"
+          else
+            echo "Creating new comment..."
+            gh api "repos/${{ github.repository }}/issues/${{ github.event.pull_request.number }}/comments" \
+              -f body="$COMMENT_BODY"
+          fi
+
   # Gathers all release data from GitHub releases triggered by this workflow
   # For use in the `update-extension-list` job
   # If no releases were triggered the output for releases will be `[]`