Simplify release-check pipeline and expand PR comment#343
Merged
dotNomad merged 1 commit intopr-release-comment-refactorfrom Apr 16, 2026
Merged
Simplify release-check pipeline and expand PR comment#343dotNomad merged 1 commit intopr-release-comment-refactorfrom
dotNomad merged 1 commit intopr-release-comment-refactorfrom
Conversation
- Consolidate the should_release step in the release-extension action: single message/output/JSON emission instead of a 3-branch helper, and use jq -n for safer JSON construction. - Gate release-check artifact upload at the action level (PRs, non-0.0.0), dropping the filter that used to live downstream. - Merge the aggregate + comment workflow steps into one; no intermediate no_release.json, no duplicate empty-check. - Expand the PR comment to summarize both will-release and won't-release extensions so contributors can confirm what will release on merge. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
juleswg23
approved these changes
Apr 16, 2026
Collaborator
juleswg23
left a comment
juleswg23
left a comment
There was a problem hiding this comment.
This looks fantastic, thanks! I especially like including the "will release" info in the comment.
Collaborator
Author
Fantastic I'll merge it into your branch |
dotNomad
added a commit
that referenced
this pull request
Apr 16, 2026
…aded (#342) * Refactor pr-release-comment to use release-check artifacts Instead of duplicating version comparison logic, the pr-release-comment job now reads release-check-*.json artifacts emitted by release-extension. This keeps the version logic in one place. Changes: - release-extension action now writes release-check JSON inline at each decision point (will release / holding back / 0.0.0) - pr-release-comment depends on release jobs instead of change-detection jobs, and aggregates the artifacts with jq Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * make comment more accurate * test: trigger reaper extension without version bump * fix: rename artifact to would-release to avoid collision with release-*.json pattern * change landing page instead of reaper * CI test: change second app without updating manifest * refactor: simplify release-check pipeline and summarize will-release (#343) - Consolidate the should_release step in the release-extension action: single message/output/JSON emission instead of a 3-branch helper, and use jq -n for safer JSON construction. - Gate release-check artifact upload at the action level (PRs, non-0.0.0), dropping the filter that used to live downstream. - Merge the aggregate + comment workflow steps into one; no intermediate no_release.json, no duplicate empty-check. - Expand the PR comment to summarize both will-release and won't-release extensions so contributors can confirm what will release on merge. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * revert README test changes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> Co-authored-by: Jordan Jensen <jordan.jensen@posit.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposed simplifications on top of #342:
should_releasestep inrelease-extension/action.yml: single message/output/JSON emission at the end of the step instead of the 3-branchwrite_release_checkhelper. Usesjq -n --arg/--argjsonfor safer JSON construction than hand-built string concatenation.pull_request && MANIFEST_VERSION != '0.0.0'), so the downstream comment job doesn't need to filter.no_release.jsonfile and duplicate empty-check are gone.