-
Notifications
You must be signed in to change notification settings - Fork 8
update for new settings panel #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ | |
| "homepage": "https://github.com/posit-dev/connect-extensions/tree/main/extensions/publisher-command-center", | ||
| "minimumConnectVersion": "2025.04.0", | ||
| "requiredFeatures": ["API Publishing", "OAuth Integrations"], | ||
| "version": "0.0.6" | ||
| "version": "0.0.7" | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It doesn't hurt anything to release this, but if it's only the readme that's changing, we don't actually need a release for that, right? the readme isn't in the thing that gets installed from the gallery for this one, right?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh great point, I was on a roll. The readme goes with the bundle, so it does technically ( i had to check to confirm just now) but I am not sure that's really used?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nods yeah I think it tags along, but the only way someone would get to it would be to download the bundle after installing.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems unlikely. I will defer to your judgement here, it also kind of strange to bump version just for readme change now that we are talking about it. |
||
| }, | ||
| "files": { | ||
| "requirements.txt": { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| Package: usage-metrics-dashboard | ||
| Version: 1.0.13 | ||
| Version: 1.0.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generic wording, no screenshots works for both old and new UI which is a good idea. One concern: for Content Health Monitor specifically, a first-time user deploying this extension sees "Open the content settings" and "Set the environment variable" without visual guidance may leave them searching for where things are.
Approach in #345 provides step by step instruction but won't match what the ~small number of users on the old settings pane see.
Since the new UI is enabled by default and the old UI is scheduled for removal in v2026.06.0 (#36191 in Connect), I'd lean toward targeting the new UI with specific instructions but the generic approach is reasonable too. Happy to go either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
late to this, since customers might be on older versions without new settings panel I lean towards keeping it generic to avoid confusion. I can add an issue to come back next year and add updates.