update color palettes#198
Merged
Merged
Conversation
teunbrand
approved these changes
Mar 17, 2026
Collaborator
teunbrand
left a comment
teunbrand
left a comment
There was a problem hiding this comment.
Mostly LGTM, two small nits to pick. I've not verified the correctness of all the hex codes myself because I'll trust you on this
Comment on lines
+13
to
+14
| "#0067A5", "#F38400", "#008856", "#F3C300", "#875692", "#A1CAF1", "#BE0032", "#8DB600", | ||
| "#654522", "#E68FAC", |
Collaborator
There was a problem hiding this comment.
This doesn't seem to be the same as the swatch_ggsql10.svg file
Collaborator
Author
There was a problem hiding this comment.
good catch - didn't regenerate after I switched back to the choice
|
|
||
| #### Sequential | ||
| Sequential palettes for numeric data. `navia` is the default continuous color palette in ggsql. | ||
| Sequential palettes for numeric data. `sequential` is the default continuous color palette in ggsql. |
Collaborator
There was a problem hiding this comment.
Should we mention that it is based on 'navia' somewhere? Doesn't need to be here, but somewhere would be nice.
Collaborator
Author
There was a problem hiding this comment.
it's already in the table
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #140
Apart from updating the continuous color palette as described in #140, this PR also fixes some issues in the palette documentation as well as reorganise the default categorical color palette.
The last point is still undecided and awaiting consensus