Fix data-panel misassignment#424
Merged
Merged
Conversation
Vega-Lite has a bug where explicit sort arrays on facet field definitions cause data-panel misalignment (vega/vega-lite#8675). Work around this by converting discrete facet column values to integer sort indices in the unified dataset and reconstructing display labels via header.labelExpr. - Split apply_facet_ordering into resolve_facet_ordering (pure: scale → index map) and apply_facet_ordering (rewrites data column to integers) - Add build_indexed_facet_label_expr to map integers back to labels, composing with user RENAMING when present - Extract apply_binned_facet_reverse for the binned sort: "descending" case (unaffected by the bug since it uses a string, not an array) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Extract the per-field facet pipeline (build def, resolve ordering, rewrite data, label renaming, binned reverse) into apply_facet_aesthetic. Hoist the shared "move layer/width/height into inner spec" block after the match. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
teunbrand
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #409.
Briefly the
"facet": {"column/row": {"sort": [...]}}sorting array is buggy upstream in VL. We circumvent the upstream problem by converting our facet columns to integer indices by matching these to the facet order. This causes the panels to sort themselves naturally in VL.There is a small effort at code duplication as well.