feat: add compact= arg to for fmt_currency()#664
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #664 +/- ##
=======================================
Coverage 91.17% 91.18%
=======================================
Files 47 47
Lines 5462 5465 +3
=======================================
+ Hits 4980 4983 +3
Misses 482 482 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
machow
requested changes
Apr 14, 2025
Collaborator
machow
left a comment
There was a problem hiding this comment.
reviewed while pairing...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the
compact=parameter tofmt_currency(), so that values such as $12,345 can render as $12.34K. The behavior ofcompact=here is the same as in other formatters likefmt_number()andfmt_integer().Here's an example of its use:
Fixes: #649