fix: move literals to types.py#672
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
==========================================
+ Coverage 91.17% 91.18% +0.01%
==========================================
Files 47 48 +1
Lines 5462 5471 +9
==========================================
+ Hits 4980 4989 +9
Misses 482 482 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Could the team help review which literals (if not all) should be included in the |
|
Initially, I considered exposing all the literals directly in |
|
Thanks for this PR -- we're actively discussing types right now. No need to update this PR right now. I'll be sure to come back with more fleshed out thoughts, if that's okay! BackgroundWe'll be working on a extension package for Great Tables (with extra nanoplots, themes, etc.. that we don't want to load up the main package too hard with), so this piece will be super relevant. Two big pieces for us to think about:
I feel like the polars._types submodule has been a helpful reference. It looks like they deprecated their |
|
We're sprinting to merge and clear many of the outstanding PRs. I'm going to close for now, but I marked the linked issue as an epic, and definitely think it'll be good for us to come back to. Thanks for taking the time to work on this, this is mostly an issue of us getting things out the door! |
Hello team,
This PR provides an initial implementation for #526.