Skip to content

tests: add no pandas dependency test of vals function#689

Merged
machow merged 1 commit into
mainfrom
test-vals-no-pandas
Jun 4, 2025
Merged

tests: add no pandas dependency test of vals function#689
machow merged 1 commit into
mainfrom
test-vals-no-pandas

Conversation

@machow
Copy link
Copy Markdown
Collaborator

@machow machow commented Jun 2, 2025

This PR adds a test of a vals function, that demonstrates it working on a Polars series, without having Pandas installed.

This is intended to provide a simple test of #675, showing Pandas is not required to use vals. However, it's fairly simple, so more testing / looking around may be needed.

@machow machow requested a review from rich-iannone as a code owner June 2, 2025 18:07
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (4a11db5) to head (9dafff7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #689   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          47       47           
  Lines        5465     5465           
=======================================
  Hits         4983     4983           
  Misses        482      482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@machow machow merged commit e290be6 into main Jun 4, 2025
14 checks passed
@rich-iannone rich-iannone deleted the test-vals-no-pandas branch June 4, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants