Skip to content

Add no pandas dep test make one column table#691

Closed
tylerriccio33 wants to merge 1 commit into
posit-dev:mainfrom
tylerriccio33:no-pandas-dep-test
Closed

Add no pandas dep test make one column table#691
tylerriccio33 wants to merge 1 commit into
posit-dev:mainfrom
tylerriccio33:no-pandas-dep-test

Conversation

@tylerriccio33
Copy link
Copy Markdown
Contributor

This is a response to #689 that tests the ability to pass a non-polars series to a table. I'm curious to see if this runs in no pandas mode, I was under the impression it wasn't

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (4a11db5) to head (fff6f71).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #691   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files          47       47           
  Lines        5465     5465           
=======================================
  Hits         4983     4983           
  Misses        482      482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tylerriccio33
Copy link
Copy Markdown
Contributor Author

So, the no pandas fails since it prohibits a list. I think simply what I'm looking for is for this test to pass. This function is called a great many times internally, and incidentally in a number of functions I need, and perhaps others (see posit-dev/pointblank#132).

Instead of using passing a series instead which would've required a number of code base changes across GT, I assumed the easiest way would be to just allow passing a list. Maybe i'm overthinking this. Happy to help w/changes and open prs

@machow
Copy link
Copy Markdown
Collaborator

machow commented Jun 4, 2025

Are you saying that you want Great Tables to use a specific library (pandas or polars) when a list is passed? Or is it that you'd like Great Tables to be able to operate without depending on any DataFrame library?

I do think we could implement a very simple DataFrame-like class inside Great Tables, that would enable it to work without any DataFrame dependency. If that's what you want, do you mind opening a feature request?

@machow
Copy link
Copy Markdown
Collaborator

machow commented Jun 5, 2025

I'm going to close for now, but please do open an issue if enabling certain parts of Great Tables to operate without any frame library dependencies would be usefully (currently it requires Pandas or Polars, and what gets used is under the user's control)

@machow machow closed this Jun 5, 2025
@tylerriccio33 tylerriccio33 deleted the no-pandas-dep-test branch June 14, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants