Add no pandas dep test make one column table#691
Conversation
f444042 to
6058917
Compare
6058917 to
fff6f71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 47 47
Lines 5465 5465
=======================================
Hits 4983 4983
Misses 482 482 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
So, the no pandas fails since it prohibits a list. I think simply what I'm looking for is for this test to pass. This function is called a great many times internally, and incidentally in a number of functions I need, and perhaps others (see posit-dev/pointblank#132). Instead of using passing a series instead which would've required a number of code base changes across GT, I assumed the easiest way would be to just allow passing a list. Maybe i'm overthinking this. Happy to help w/changes and open prs |
|
Are you saying that you want Great Tables to use a specific library (pandas or polars) when a list is passed? Or is it that you'd like Great Tables to be able to operate without depending on any DataFrame library? I do think we could implement a very simple DataFrame-like class inside Great Tables, that would enable it to work without any DataFrame dependency. If that's what you want, do you mind opening a feature request? |
|
I'm going to close for now, but please do open an issue if enabling certain parts of Great Tables to operate without any frame library dependencies would be usefully (currently it requires Pandas or Polars, and what gets used is under the user's control) |
This is a response to #689 that tests the ability to pass a non-polars series to a table. I'm curious to see if this runs in no pandas mode, I was under the impression it wasn't