Fix: Modify the group labels when render_formats() is called#769
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
==========================================
+ Coverage 92.31% 92.36% +0.05%
==========================================
Files 49 48 -1
Lines 6009 6037 +28
==========================================
+ Hits 5547 5576 +29
+ Misses 462 461 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
Collaborator
|
This is great, thanks! Sorry for taking so long to get to the PR. @rich-iannone is onboard with helping pull the logic out of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply
fmt()output to group labels in the stub.This approach goes upstream of the approach in #755. It is admittedly, a little heavier-weight, but does still happen at render time. The advantage to this over #755 is that we are modifying the group label before the html rendering, so this will apply to latex tables. Additionally, it takes advantage of the stubbed out
group_row.group_labelattribute.Previously, this code block had the following output.
Now we see this output:
Related GitHub Issues and PRs
closes #761
We could also close #236 if this PR is merged.
Checklist