fix: prepend charset meta tag to HTML in save()#823
Open
mrapacz wants to merge 2 commits intoposit-dev:mainfrom
Open
fix: prepend charset meta tag to HTML in save()#823mrapacz wants to merge 2 commits intoposit-dev:mainfrom
mrapacz wants to merge 2 commits intoposit-dev:mainfrom
Conversation
mrapacz
force-pushed
the
fix-unicode-save-charset
branch
from
e8b68bd to
005a01d
Compare
Headless browsers (like Chrome) can misidentify the encoding of an HTML fragment and corrupt Unicode characters. Prepending <meta charset='utf-8'> ensures that the characters are rendered correctly in the resulting image file.
mrapacz
force-pushed
the
fix-unicode-save-charset
branch
from
005a01d to
f336ebe
Compare
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
=======================================
Coverage 92.32% 92.32%
=======================================
Files 48 48
Lines 6056 6056
=======================================
Hits 5591 5591
Misses 465 465 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Headless browsers (like Chrome) can misidentify the encoding of an HTML fragment and corrupt Unicode characters.
Fix: Added a one-liner change as suggested by @rich-iannone, prepending raw html with
<meta charset='utf-8'>to make the webdriver recognize encoding and render characters correctly in the resulting image file.Related GitHub Issues and PRs
Checklist
N/A - There was no test that would catch this beforehand and I wasn't sure testing 'when we prepend a string with another string, we should test that the prefix is there' warrants a new unit test. But if you think it does, let me know and I'll be happy to add it :)