test: add failing footnote target regressions#828
Closed
t-kalinowski wants to merge 1 commit into
Closed
Conversation
Add regression coverage for footnote targets that currently produce footer entries without rendering a corresponding mark at the target location. The new tests cover three public API cases: - row group footnotes created with loc.row_groups(), where the footer note is present but the row group heading does not receive a footnote mark - grand summary body footnotes created with loc.grand_summary(), where the footer note is present but the targeted grand summary cell does not receive a footnote mark - spanner footnotes created with loc.spanner_labels(ids=...) when the spanner id differs from the displayed label, where lookup currently misses the target because rendering matches against label text instead of the spanner id These tests document the expected rendered HTML behavior and should pass once footnote marks are applied to all supported target locations and spanner footnote matching uses stable spanner ids.
Member
Author
|
Opened PR against wrong branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add regression coverage for footnote targets that currently produce footer entries without rendering a corresponding mark at the target location.
The new tests cover three public API cases:
These tests document the expected rendered HTML behavior and should pass once footnote marks are applied to all supported target locations and spanner footnote matching uses stable spanner ids.