Re-add bakery-pr CI job using full repo path#451
Merged
Conversation
The relative path caused startup_failure because GitHub couldn't resolve it during PR validation. The full repo path resolves from the published main branch.
bakery-build-pr.yml was added in #442 but missed the SHA-pinning pass in #443. Pin all third-party actions to full-length commit SHAs matching bakery-build-native.yml, and add timeout-minutes to all three jobs (detect: 5m, matrix: 10m, build-test: 120m). - Upgrade oras-project/setup-oras from v1 to v2.0.0 for consistency with the native build workflow - First-party composite actions (setup-bakery, setup-goss) intentionally kept at @main per zizmor ref-pin policy
Now that bakery-build-pr.yml exists on main (merged in #442), the relative ref resolves correctly. This matches the pattern used by bakery-build.yml and bakery-build-native.yml, and lets PRs that modify bakery-build-pr.yml test their own changes.
The job-level `if` referencing `matrix.img.platform` caused a workflow validation error — the matrix context is not available in job-level `if` expressions. Move the arm64 fork-skip logic into the matrix job, which filters arm64 entries from the platform matrix output when the PR is from a fork.
Test Results1 328 tests 1 328 ✅ 7m 46s ⏱️ Results for commit e958576. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-add the
bakery-prtest job toci.ymlusing the full repo path (posit-dev/images-shared/.github/workflows/bakery-build-pr.yml@main) instead of a relative path. The relative path causedstartup_failureon PRs because GitHub couldn't resolve recently-added workflow files.Depends on #449.
Test plan
bakery-prjob runs on pull_request eventsbakery-prjob skips on push/tag events (allowed-skips)