Strip v prefix from image-version input#496
Merged
bschwedler merged 2 commits intomainfrom Apr 28, 2026
Merged
Conversation
ianpittwood
approved these changes
Apr 28, 2026
| DEV_STREAM: ${{ inputs.dev-stream }} | ||
| CONTEXT: ${{ inputs.context }} | ||
| run: | | ||
| IMAGE_VERSION="${IMAGE_VERSION#v}" |
Contributor
There was a problem hiding this comment.
We may want to consider adding a callout in CI.md
Product repos dispatch with a git-describe version that may include
a leading v (e.g. v2026.03.0-473-g072bb6fd1f). Bakery version names
never have this prefix, so the --image-version filter matches nothing
and the matrix is empty.
Strip the prefix with ${IMAGE_VERSION#v} before building the CLI
args. Also separate the bakery ci matrix call from the echo so that
set -e catches a non-zero exit (previously the exit code was
swallowed inside a command substitution within echo).
- Update image-version input descriptions to note the automatic v prefix strip. - Fix swallowed exit code in bakery-build-pr.yml (same echo+subshell pattern as the build workflows). - Add image-version and dev-stream to both input tables in CI.md. - Add "Dispatched version doesn't match bakery" to CLAUDE.md CI failure modes.
07a1c30 to
2bf6f89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the empty-matrix failure seen on https://github.com/posit-dev/images-connect/actions/runs/25058571626 — the first real dispatch from a product repo after #480 landed.
Product repos dispatch with a git-describe version like
v2026.03.0-473-g072bb6fd1f. Bakery version names never carry thevprefix, so--image-versionmatched nothing and the matrix came back empty.Changes
vfromIMAGE_VERSIONwith${IMAGE_VERSION#v}before building CLI args (bothbakery-build-native.ymlandbakery-build.yml).bakery ci matrixfrom theechothat writes$GITHUB_OUTPUTsoset -ecan catch non-zero exits. Previously the exit code was swallowed inside a command substitution withinecho.Test plan