Push image versions in deterministic order to fix Docker Hub display#505
Merged
Conversation
ianpittwood
force-pushed
the
feature/ordered-push
branch
from
cba8966 to
d53badd
Compare
ianpittwood
force-pushed
the
feature/ordered-push
branch
from
d53badd to
bc0fca7
Compare
bschwedler
reviewed
May 12, 2026
ianpittwood
force-pushed
the
feature/ordered-push
branch
from
3248065 to
18e777d
Compare
Fix import ordering in image_target.py (parsed_version after build_secret), hoist ParsedVersion import to top of test file per CLAUDE.md policy, and remove dead isMatrixVersion assignment on mock that had no effect on tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Move `import logging` from inside the test method to the top-level stdlib imports block, following the project's import policy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ianpittwood
force-pushed
the
feature/ordered-push
branch
from
18e777d to
4af94c3
Compare
bschwedler
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImageTarget.push_sort_key, a sort tuple driving Docker Hub display order:(image_name, is_latest, ParsedVersion key, primary_score, version.name, variant.name, os.name). Latest pushes last; ties broken by primary OS+variant; multi-image runs grouped per image.OrasPlugin.executeand emitslog.info("ORAS merge order: ...")so CI logs make the chosen order observable.bakery-build-native.ymlmergematrix into a single ordered job; drops the now-unusedversions-matrixoutput and theImages by Versionstep. Build/test fan-out is unchanged.Closes #484.
Dependencies
Builds on (must land first or merge together):
ParsedVersionvalue type andversion_sort_keyhelperlatest=Trueon the canonical matrix combinationBoth are merged into this branch already, so the diff against
mainwill collapse to just the ordered-push commits once they land.Trade-off
Wall-time on the
mergejob grows because pushes are now sequential rather than parallel:connect-contentmatrix (~12 combos × variants)push: false, dry-run)Total runner-minutes drop because per-runner setup (Docker, buildx, ORAS) only runs once.
Test plan
just test— 1487 passed, 0 failures, 84% coverageTestPushSortKey(7 new tests): latest-last, primary-within-version, version ordering, semver §11 prerelease (daily < dev < release), matrix non-latest tiebreakers, matrix latest sorts last, multi-image groupingOrasPlugin.executeordering test: scrambled input → sorted output, exactly oneORAS merge order:log linepre-commitactionlint hook onbakery-build-native.yml— cleanORAS merge order:line in CI log shows the expected sequencehub.docker.com/r/posit/connectand confirm thelatest-aliased tag is the most-recent pushposit/connect-contentafter the next content workflow run (uses Implement latest tag for image matrix builds #501'slatest_combination)