Move test scratch artifacts out of repo root (#75)

Route checkout-scoped test scratch directories through target/test-scratch so interrupted or failed test runs do not leave .tmp-style artifacts in the repository root. Keep sandbox-sensitive scratch outside OS temp where tests need read-only cwd writes to be blocked, while moving the worker-process unit-test scratch to OS temp.

Author: t-kalinowski

src/worker_process.rs

@@ -7212,6 +7212,15 @@ mod tests {
             .unwrap_or_else(|err| err.into_inner())
     }
 
+    #[cfg(target_family = "unix")]
+    fn worker_process_test_temp_parent(label: &str) -> PathBuf {
+        let root = std::env::temp_dir()
+            .join("mcp-repl-test-scratch")
+            .join(label);
+        std::fs::create_dir_all(&root).expect("create worker process test temp parent");
+        root
+    }
+
     #[test]
     fn python_backend_prepares_windows_sandbox_launch() {
         assert!(
@@ -9829,7 +9838,7 @@ mod tests {
         let _guard = cwd_test_mutex().lock().expect("cwd mutex");
         let temp = tempfile::Builder::new()
             .prefix(".tmp-interrupt-tail-current-sandbox-")
-            .tempdir_in(env!("CARGO_MANIFEST_DIR"))
+            .tempdir_in(worker_process_test_temp_parent("worker-process"))
             .expect("tempdir");
         let sandbox_cwd = temp.path().to_path_buf();
         let plan = SandboxCliPlan {

tests/common/mod.rs

@@ -36,6 +36,15 @@ const WINDOWS_TEST_TIMEOUT_CAP_SECS: f64 = 60.0;
 #[cfg(windows)]
 const WINDOWS_TEST_SERVER_MUTEX_NAME: &str = "Local\\mcp_repl_test_server_mutex";
 
+pub(crate) fn checkout_test_temp_parent(label: &str) -> TestResult<PathBuf> {
+    let root = PathBuf::from(env!("CARGO_MANIFEST_DIR"))
+        .join("target")
+        .join("test-scratch")
+        .join(label);
+    std::fs::create_dir_all(&root)?;
+    Ok(root)
+}
+
 #[cfg(windows)]
 struct WindowsSuiteServerMutexOwner {
     release_tx: std::sync::mpsc::Sender<()>,

tests/sandbox_state_updates.rs

@@ -200,7 +200,28 @@ fn home_scratch_dir(label: &str) -> TestResult<TempDir> {
 fn repo_scratch_dir(label: &str) -> TestResult<TempDir> {
     Ok(Builder::new()
         .prefix(&format!(".tmp-{label}-"))
-        .tempdir_in(env!("CARGO_MANIFEST_DIR"))?)
+        .tempdir_in(common::checkout_test_temp_parent("sandbox-state-updates")?)?)
+}
+
+#[test]
+fn repo_scratch_dir_uses_non_temp_checkout_scratch_parent() -> TestResult<()> {
+    let scratch = repo_scratch_dir("parent")?;
+    assert_ne!(
+        scratch.path().parent(),
+        Some(Path::new(env!("CARGO_MANIFEST_DIR"))),
+        "test scratch dirs must not be created directly in the repo root"
+    );
+    assert!(
+        scratch
+            .path()
+            .starts_with(common::checkout_test_temp_parent("sandbox-state-updates")?),
+        "sandbox cwd scratch dirs should stay under target/test-scratch"
+    );
+    assert!(
+        !scratch.path().starts_with(std::env::temp_dir()),
+        "sandbox cwd scratch dirs must stay outside OS temp so read-only sandbox tests can observe blocked cwd writes"
+    );
+    Ok(())
 }
 
 fn write_file_code(path: &Path) -> TestResult<String> {

tests/write_stdin_behavior.rs

@@ -96,7 +96,27 @@ fn r_path_literal(path: &Path) -> TestResult<String> {
 fn workspace_tempdir() -> TestResult<tempfile::TempDir> {
     Ok(tempfile::Builder::new()
         .prefix("mcp-repl-write-stdin-")
-        .tempdir_in(env!("CARGO_MANIFEST_DIR"))?)
+        .tempdir_in(common::checkout_test_temp_parent("write-stdin")?)?)
+}
+
+#[test]
+fn workspace_tempdir_uses_non_temp_checkout_scratch_parent() -> TestResult<()> {
+    let temp = workspace_tempdir()?;
+    assert_ne!(
+        temp.path().parent(),
+        Some(Path::new(env!("CARGO_MANIFEST_DIR"))),
+        "test scratch dirs must not be created directly in the repo root"
+    );
+    assert!(
+        temp.path()
+            .starts_with(common::checkout_test_temp_parent("write-stdin")?),
+        "workspace scratch dirs should stay under target/test-scratch"
+    );
+    assert!(
+        !temp.path().starts_with(std::env::temp_dir()),
+        "workspace scratch dirs must stay outside OS temp because some tests remove or override worker temp env"
+    );
+    Ok(())
 }
 
 async fn wait_until_path_exists(path: &Path, label: &str) -> TestResult<()> {