Centralize stdin payload and control-prefix semantics#74
Merged
Conversation
62ab341 to
747eafb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralizes stdin payload preparation, control-prefix splitting, and timeout bundle reuse classification in
src/stdin_payload.rs.This removes duplicated stdin/control logic from worker request handling and response finalization, so Ctrl-C/Ctrl-D semantics and worker stdin newline handling have one source of truth.
User-facing changes
None intended. The
repltool interface is unchanged; this PR preserves and codifies stdin/control edge-case behavior.Internal changes
stdin_payloadas the shared module for stdin payload construction, control-prefix splitting, and timeout bundle reuse classification.server/response.rsto re-export and use the shared timeout reuse classifier.Testing
cargo +nightly fmtcargo checkcargo buildcargo clippy --all-targets --all-features -- -D warningscargo test