Skip to content

Move test scratch artifacts out of the repo root#75

Merged
t-kalinowski merged 1 commit into
mainfrom
fix/test-scratch-artifacts
May 20, 2026
Merged

Move test scratch artifacts out of the repo root#75
t-kalinowski merged 1 commit into
mainfrom
fix/test-scratch-artifacts

Conversation

@t-kalinowski
Copy link
Copy Markdown
Member

Summary

This moves test scratch directories out of the repository root so interrupted or failed test runs do not leave .tmp-* or similar artifacts in the working tree. The change keeps sandbox-sensitive scratch under target/test-scratch instead of OS temp because those tests need cwd writes to be blocked under read-only sandbox policy, and some timeout tests intentionally remove or override temp env paths.

User-facing changes

None. This only affects test scratch placement.

Internal changes

  • Added a shared checkout-local scratch parent helper under target/test-scratch.
  • Moved write-stdin and sandbox-state scratch dirs to that helper.
  • Added regressions that assert scratch dirs are not created directly in the repo root and stay outside OS temp where required.
  • Moved one worker-process unit-test scratch path to OS temp because it does not rely on sandbox cwd/temp semantics.

Route checkout-scoped test scratch directories through target/test-scratch so interrupted or failed test runs do not leave .tmp-style artifacts in the repository root. Keep sandbox-sensitive scratch outside OS temp where tests need read-only cwd writes to be blocked, while moving the worker-process unit-test scratch to OS temp.
@t-kalinowski t-kalinowski merged commit dbf22fe into main May 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant