Fix manual workflow_dispatch for regular monthly releases#352
Merged
Conversation
✅ Deploy Preview for positron-posit-co ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#337 added a
create_releaseinput to gate whether the workflow creates a new GitHub release or uploads assets to an existing one, but only declared it underworkflow_call. Manualworkflow_dispatchruns evaluatedinputs.create_releaseas empty, skipped "Create Release", and fell through to "Upload assets to existing release", which failed withrelease not found(e.g. the run I just did for today's release: https://github.com/posit-dev/positron-website/actions/runs/25339184081).This PR adds
create_releaseto theworkflow_dispatchinputs withdefault: trueso manual runs create a fresh release by default, with a checkbox to opt into the upload-only path. Theworkflow_callcaller inposit-dev/positron-builds(update-workbench.yml) is unaffected; it passescreate_release: falseexplicitly.