Commit 57deef8
authored
feat: animate notebook cell execution footer expand/collapse (#12946)
Partially addresses #11775
Hide the cell execution footer when a cell has never been run or was
only run in a previous session. The footer collapses with a CSS
transition (height, opacity, borders) and expands when the cell is
queued or executed.
### Demo
_The execution info smoothly slides in and out as the info is
available._
https://github.com/user-attachments/assets/e5876226-1d5d-4e10-817b-9ec864197b59
- Respects `prefers-reduced-motion` by disabling transitions
- ARIA labels suppressed on collapsed footers via `aria-hidden`
- Active states (running/pending) prioritized over static states in ARIA
label ordering
- Border radius adjusts when footer is collapsed and no outputs are
present
#### Performance
In theory this could be a performance issue with really large notebooks
because the animation triggers a reflow of lower cells. In practice,
it's not bad as if a cell has no output it's not _normally_ followed by
a bunch of cells with outputs. Also the animations are all done with CSS
so they're fairly optimized. I tested with a notebook with ~100 cells
and didnt notice any real performance issues but we can/should keep an
eye on it.
### Release Notes
#### New Features
- Notebook cell execution footer now hides when the cell has not been
run and smoothly animates in/out during execution
#### Bug Fixes
- N/A
### QA Notes
@:notebooks @:positron-notebooks
2. Verify cells that have never been run do NOT show the execution
footer
3. Run a cell -- footer should animate in and show timing info
4. Add a new cell without running it -- footer should not be visible
5. Queue multiple cells -- footer should appear immediately for pending
cells
6. Check with system reduced-motion enabled -- transitions should be
instant1 parent 13f1217 commit 57deef8
5 files changed
Lines changed: 65 additions & 15 deletions
File tree
- src/vs/workbench/contrib/positronNotebook/browser/notebookCells
- test/e2e
- pages
- tests/notebooks-positron
Lines changed: 18 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| 13 | + | |
13 | 14 | | |
14 | 15 | | |
15 | 16 | | |
| |||
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
28 | 46 | | |
29 | 47 | | |
30 | 48 | | |
| |||
Lines changed: 21 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
77 | 78 | | |
78 | 79 | | |
79 | 80 | | |
80 | | - | |
| 81 | + | |
81 | 82 | | |
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
85 | 86 | | |
86 | 87 | | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
87 | 93 | | |
88 | 94 | | |
89 | 95 | | |
| |||
147 | 153 | | |
148 | 154 | | |
149 | 155 | | |
150 | | - | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
151 | 159 | | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | 160 | | |
161 | 161 | | |
162 | 162 | | |
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
168 | 176 | | |
169 | 177 | | |
170 | 178 | | |
| |||
181 | 189 | | |
182 | 190 | | |
183 | 191 | | |
184 | | - | |
| 192 | + | |
| 193 | + | |
185 | 194 | | |
186 | | - | |
| 195 | + | |
187 | 196 | | |
188 | 197 | | |
189 | 198 | | |
| |||
Lines changed: 11 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
79 | 86 | | |
80 | 87 | | |
81 | 88 | | |
| |||
201 | 208 | | |
202 | 209 | | |
203 | 210 | | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
204 | 215 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1145 | 1145 | | |
1146 | 1146 | | |
1147 | 1147 | | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
| 1152 | + | |
| 1153 | + | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
1148 | 1160 | | |
1149 | 1161 | | |
1150 | 1162 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
94 | | - | |
| 93 | + | |
| 94 | + | |
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
0 commit comments