Commit 6671bb3
authored
ci: fix e2e-failure-analyzer for positron-builds caller (#13693)
## Summary
Three follow-ups to
[#13671](#13671) needed before
the e2e-failure-analyzer action can run from
[posit-dev/positron-builds](https://github.com/posit-dev/positron-builds),
where the action lives in a submodule and the test source isn't at
`$GITHUB_WORKSPACE`. All in
[.github/actions/e2e-failure-analyzer/action.yml](.github/actions/e2e-failure-analyzer/action.yml):
- Apply `inputs.repo-root || github.workspace` at all five consumers.
#13671 wired the input through to `REPO_ROOT` but left the four
helper-script paths hardcoded to `github.workspace`, so positron-builds
hit `MODULE_NOT_FOUND` on the first script call.
- Change the `repo-root` default from `${{ github.workspace }}` to `""`.
Input defaults aren't guaranteed to evaluate expressions reliably across
all contexts; falling back at each usage site is the defensive pattern
(also flagged by roborev on #13671).
- Replace the `REPORT_DIR` pipeline (`grep | grep | head -1`) with a
single `awk` pass. Under `set -e -o pipefail`, `head -1` closes its
stdin after the first match and upstream `grep` gets SIGPIPE while
writing the next line — kills the step on real CI log payloads.
The existing positron caller
([analyze-e2e-failures.yml](.github/workflows/analyze-e2e-failures.yml))
doesn't pass `repo-root`, so the `||` fallback resolves to
`github.workspace` everywhere — behavior is unchanged for in-repo runs.
## Test plan
- [ ] Trigger `Analyze E2E Failures` on positron against a recent failed
run; confirm the gather/process/history steps still find the helper
scripts at `$GITHUB_WORKSPACE/.claude/skills/...` and the analyzer reads
test source as before.
- [ ] Once merged, bump positron-builds' submodule pin to this SHA and
confirm the end-to-end analyzer run succeeds with `repo-root: ${{
github.workspace }}/positron`.1 parent aba28d9 commit 6671bb3
1 file changed
Lines changed: 12 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | | - | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
| 68 | + | |
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
159 | | - | |
160 | | - | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
161 | 163 | | |
162 | 164 | | |
163 | | - | |
164 | | - | |
165 | | - | |
| 165 | + | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| |||
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
176 | | - | |
| 176 | + | |
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
199 | | - | |
| 199 | + | |
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
| |||
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
217 | | - | |
| 217 | + | |
218 | 218 | | |
219 | 219 | | |
220 | 220 | | |
| |||
0 commit comments