Skip to content

Commit a63862c

Browse files
committed
Remove interpreter selector from Packages pane and update tests
- Delete unused PackagesInstanceMenuButton component - Update e2e test to not check for version button (no longer exists) - Minor style: use Boolean() instead of !! for context key See #12922
1 parent 4612fdc commit a63862c

3 files changed

Lines changed: 4 additions & 73 deletions

File tree

src/vs/workbench/contrib/positronPackages/browser/components/packagesInstanceMenuButton.tsx

Lines changed: 0 additions & 64 deletions
This file was deleted.

src/vs/workbench/contrib/positronPackages/browser/positronPackagesService.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ export class PositronPackagesService extends Disposable implements IPositronPack
106106
this._activeInstance = instance;
107107

108108
// Update context keys
109-
this._hasActiveSessionContextKey.set(!!instance);
109+
this._hasActiveSessionContextKey.set(Boolean(instance));
110110

111111
// Clear previous instance's busy state tracking
112112
this._activeInstanceDisposables.clear();

test/e2e/tests/environment-pane/environment-pane.test.ts

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,14 @@ test.describe('Environment Pane', {
2525
await getPackagesButton(page).click();
2626
});
2727

28-
async function verifyPackagesList(page: any, expectedVersion: string) {
28+
async function verifyPackagesList(page: any) {
2929
// Click on the Packages button in the environment pane
3030
await getPackagesButton(page).click();
3131

3232
// Verify the packages list is displayed
3333
const packagesContainer = page.locator('.positron-packages-list');
3434
await expect(packagesContainer).toBeVisible();
3535

36-
// Verify button contains the expected version
37-
const versionButton = packagesContainer.locator('.action-bar-region-left button').first();
38-
await expect(versionButton).toBeVisible();
39-
await expect(versionButton).toContainText(expectedVersion);
40-
4136
// Verify package list items are present
4237
const packageItems = packagesContainer.locator('.packages-list-item-name');
4338
await expect(packageItems.first()).toBeVisible();
@@ -46,10 +41,10 @@ test.describe('Environment Pane', {
4641
}
4742

4843
test('Python - Click packages button', async function ({ page, python: _python }) {
49-
await verifyPackagesList(page, process.env.POSITRON_PY_VER_SEL!);
44+
await verifyPackagesList(page);
5045
});
5146

5247
test('R - Click packages button', async function ({ page, r: _r }) {
53-
await verifyPackagesList(page, process.env.POSITRON_R_VER_SEL!);
48+
await verifyPackagesList(page);
5449
});
5550
});

0 commit comments

Comments
 (0)