Commit d5f94f0
authored
Bump ark to rename branch (#13820)
Closes #13749
Closes #8631
Progress towards #4525
For Ark-side PRs:
- posit-dev/ark#1230
- posit-dev/ark#1231
- posit-dev/ark#1232
<!-- Thank you for submitting a pull request.
If this is your first pull request you can find information about
contributing here:
* https://github.com/posit-dev/positron/blob/main/CONTRIBUTING.md
We recommend synchronizing your branch with the latest changes in the
main branch by either pulling or rebasing.
-->
<!--
Describe briefly what problem this pull request resolves, or what
new feature it introduces. Include screenshots of any new or altered
UI. Reference the associated issue with a closing keyword such as
"Fixes #123" so GitHub automatically closes the issue when this PR
is merged. If there are any details about your approach that are
unintuitive or you want to draw attention to, please describe them
here.
-->
### Release Notes
<!--
Optionally, replace `N/A` with text to be included in the next release
notes.
The `N/A` bullets are ignored. If you refer to one or more Positron
issues,
these issues are used to collect information about the feature or
bugfix, such
as the relevant language pack as determined by Github labels of type
`lang: `.
The note will automatically be tagged with the language.
These notes are typically filled by the Positron team. If you are an
external
contributor, you may ignore this section.
-->
#### New Features
- You can now rename local symbols in R files
(#13749). Renaming symbols
across files is still unsupported, but will be implemented soon.
- The "Go to Definition" and "Find References" gain support for local
symbols in R files (#8631).
You can now use these functionalities to jump to where a variable is
defined (e.g. via `<-` or a function parameter), or see all references
to a variable in a function.
#### Bug Fixes
- N/A
### Validation Steps
@:ark
<!--
Positron team members: please add relevant e2e test tags, so the tests
can be
run when you open this pull request.
- Instructions:
https://github.com/posit-dev/positron/blob/main/test/e2e/README.md#pull-requests-and-test-tags
- Available tags:
https://github.com/posit-dev/positron/blob/main/test/e2e/infra/test-runner/test-tags.ts
-->
<!--
Add additional information on how to validate the change, paying
special attention to the level of risk, adjacent areas that could
be affected by the change, and any important contextual information
not present in the linked issues.
-->1 parent 45af5ca commit d5f94f0
1 file changed
Lines changed: 1 addition & 1 deletion
- Cargo.lock+2-8
- crates/ark/src/lsp.rs+4-1
- crates/ark/src/lsp/backend.rs+27-1
- crates/ark/src/lsp/diagnostics.rs+4-4
- crates/ark/src/lsp/find_references.rs+92-60
- crates/ark/src/lsp/goto_definition.rs+78-119
- crates/ark/src/lsp/goto_definition_legacy.rs-268
- crates/ark/src/lsp/handlers.rs+23-8
- crates/ark/src/lsp/main_loop.rs+14-11
- crates/ark/src/lsp/rename.rs+83
- crates/ark/src/lsp/state.rs-297
- crates/ark/src/lsp/state_handlers.rs+7
- crates/ark/src/lsp/tests.rs+4
- crates/ark/src/lsp/tests/find_references.rs+276
- crates/ark/src/lsp/tests/goto_definition.rs+151
- crates/ark/src/lsp/tests/rename.rs+129
- crates/ark/src/lsp/tests/utils.rs+17
- crates/ark/tests/lsp.rs+44
- crates/ark_test/src/lsp_client.rs+48-5
- crates/oak_core/Cargo.toml+1
- crates/oak_core/src/identifier.rs+232
- crates/oak_core/src/lib.rs+1
- crates/oak_db/src/legacy.rs-51
- crates/oak_db/src/lib.rs-3
- crates/oak_ide/Cargo.toml+1-7
- crates/oak_ide/src/external_scope.rs-136
- crates/oak_ide/src/find_references.rs+118
- crates/oak_ide/src/goto_definition.rs+35-188
- crates/oak_ide/src/identifier.rs+91-12
- crates/oak_ide/src/lib.rs+26-17
- crates/oak_ide/src/rename.rs+79
- crates/oak_ide/tests/find_references.rs+334
- crates/oak_ide/tests/goto_definition.rs+583-708
- crates/oak_ide/tests/rename.rs+225
- crates/oak_semantic/Cargo.toml+1-4
- crates/oak_semantic/src/external.rs-108
- crates/oak_semantic/src/lib.rs-3
- crates/oak_semantic/src/library.rs+4-28
- crates/oak_semantic/src/package_definitions.rs-165
- crates/oak_semantic/src/scope_layer.rs-112
- crates/oak_semantic/src/semantic_index.rs+48-12
- crates/oak_semantic/tests/builder.rs+2-2
- crates/oak_semantic/tests/external.rs-604
0 commit comments