Unify runtime status shown across UIs by dhruvisompura · Pull Request #13376 · posit-dev/positron

dhruvisompura · 2026-05-05T00:57:47Z

Based off feedback from @seeM in #13045

Three places show runtime status — the console tab icon, the notebook session badge, and the Quarto session badge. Each had its own mapping chain to get from a runtime session's state to a display icon:

Console: PositronConsoleState -> RuntimeStatus
Notebook: RuntimeState -> KernelStatus -> RuntimeStatus
Quarto: RuntimeState -> QuartoKernelState -> RuntimeStatus

These mappings can easily drift to show different states and for a notebook user this can be odd/confusing since we show the runtime status icon in multiple places.

One visible fix from this change is in the console which previously would show the wrong state during restart compared to the interpreter picker.

NOTE: the interpreter picker can become out of sync with the notebook kernel badge and notebook console session when a user chooses the "Change Kernel" option. This is also the case for Quarto as well. I didn't attempt to resolve that here and this may be worth tackling instead when we try and unify the quarto/notebook UI.

I think that fix gets us one step closer to unifying the runtime statuses.

Screenshots

BEFORE - notebook restart

before.mov

AFTER - notebook restart

Screen.Recording.2026-05-05.at.6.40.29.PM.mov

BEFORE - console restart

before.console.mov

AFTER - console restart

TBD

Release Notes

New Features

N/A

Bug Fixes

N/A

Validation Steps

@:console @:positron-notebooks @:quarto @:sessions

github-actions · 2026-05-05T00:58:06Z

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:console @:positron-notebooks @:quarto @:sessions

^readme ^{valid tags}

seeM

Notebook and console runtime status icons look correct but Quarto restart has an additional "Starting" state with a disconnected status.

Screen.Recording.2026-05-07.at.15.59.57.mov

seeM · 2026-05-07T14:11:19Z

-					// update the kernel status to the runtime session state
-					this.kernelStatus.set(KernelStatus.Starting, undefined);
-				}
+			if (newKernel && oldKernel) {


There is a regression here. Previously, switching interpreters would show immediate UI feedback via the spinner. Now there's a delay.

Before:

Screen.Recording.2026-05-07.at.16.10.02.mov

After:

Screen.Recording.2026-05-07.at.16.09.35.mov

ah, thanks for catching!

seeM · 2026-05-07T14:18:28Z

+	return <div data-testid={'state'}>{state ?? 'none'}</div>;
+};
+
+describe('useSessionRuntimeState', () => {


Nice 👌 I'm curious if you used the Claude skill here, and if so how much you had to intervene manually?

yep, I used the skill here for all of the tests. It did a pretty decent job with the simpler tsx files. I did have to go and remove some tests that were testing the wrong thing or didn't make a lot of sense to me. It wasn't that much work to fix it though since most of the time its just removing tests.

seeM · 2026-05-07T14:22:52Z

+	it('shows active icon during Restarting (regression: previously showed stale state via PositronConsoleState)', () => {
+		const { session, emitter } = makeSession(RuntimeState.Idle);
+		rtl.render(<ConsoleSessionStatusIcon positronConsoleInstance={makeInstance(session)} />);
+		act(() => emitter.fire(RuntimeState.Restarting));
+		expect(screen.getByTestId('runtime-status-active')).toBeInTheDocument();
+	});


How about writing the test with the preferred behavior and using it.fails?

seeM · 2026-05-07T14:30:33Z

+const quartoStateToRuntimeStatus: Partial<Record<QuartoKernelState, RuntimeStatus>> = {
 	[QuartoKernelState.None]: RuntimeStatus.Disconnected,
-	[QuartoKernelState.Starting]: RuntimeStatus.Active,
-	[QuartoKernelState.Ready]: RuntimeStatus.Idle,
-	[QuartoKernelState.Busy]: RuntimeStatus.Active,
 	[QuartoKernelState.Error]: RuntimeStatus.Disconnected,
-	[QuartoKernelState.ShuttingDown]: RuntimeStatus.Active,
 };


Nit: I think this would give a more accurate and helpful type - have not tested

Suggested change

const quartoStateToRuntimeStatus: Partial<Record<QuartoKernelState, RuntimeStatus>> = {

[QuartoKernelState.None]: RuntimeStatus.Disconnected,

[QuartoKernelState.Starting]: RuntimeStatus.Active,

[QuartoKernelState.Ready]: RuntimeStatus.Idle,

[QuartoKernelState.Busy]: RuntimeStatus.Active,

[QuartoKernelState.Error]: RuntimeStatus.Disconnected,

[QuartoKernelState.ShuttingDown]: RuntimeStatus.Active,

};

const quartoStateToRuntimeStatus = {

[QuartoKernelState.None]: RuntimeStatus.Disconnected,

[QuartoKernelState.Error]: RuntimeStatus.Disconnected,

} satisfies Partial<Record<QuartoKernelState, RuntimeStatus>>;

…rectives

The `runOnChange(this.kernel, ...)` block only set Switching when both oldKernel and newKernel were set, so first-time selection left kernelStatus at Unselected and the badge briefly rendered Disconnected with the kernel's runtime name. Make the badge show Active as soon as a kernel is selected, rather than waiting for the session to attach. Replace `useNotebookRuntimeSession` with a `runtimeSession` observable on IPositronNotebookInstance. The hook duplicated session resolution the model already does in `_maybeAttachSession` (initial lookup + onWillStartSession + onDidEndSession). Mirrors the existing `kernel` observable pattern.

Disambiguates the enum name, and replaces the `undefined` sentinel that meant "session is attached" with an explicit `Connected` value so the type is honest. `kernelStatus` is now `IObservable<NotebookKernelStatus>` without the `| undefined` widening.

…tching When a notebook foreground session is deleted during a kernel switch, foregroundSessionDisplayInfo briefly surfaces the deleted session's Exited state, which makes the interpreter picker flash Disconnected before the new session takes foreground. The notebook badge avoids this because it reads session state directly. Document the desired picker behavior with `it.fails` so a future fix can deal with this

The badge prioritized live runtime state over kernelStatus, so when the user picked a new kernel `kernelStatus = Switching` was set but the old session was still Idle and won the display. The spinner only kicked in once the old session started exiting -- a perceptible delay vs. clicking. Add a Switching override at the top of the ladder so user intent shows immediately, regardless of the old session's now-stale state. _maybeAttachSession clears Switching when the new session attaches, after which live runtime state takes over.

seeM

Looks great! I noticed another issue but it's in release builds too so isn't a regression, might already be on your radar. Starting an exited notebook session behaves differently in the notebook kernel status and top interpreter picker

Screen.Recording.2026-05-11.at.13.05.20.mov

dhruvisompura · 2026-05-12T01:44:07Z

Looks great! I noticed another issue but it's in release builds too so isn't a regression, might already be on your radar. Starting an exited notebook session behaves differently in the notebook kernel status and top interpreter picker

Screen.Recording.2026-05-11.at.13.05.20.mov

Ya, I noticed the same thing and it is on my radar. This has the same issue as switching kernels and the interpreter picker being out of sync with that.

dhruvisompura added 6 commits May 4, 2026 13:27

Add useSessionRuntimeState hook

c2c7711

Add data-testid for testing purposes

fb7c5de

Drive console session status icon from session RuntimeState

94b22f5

Drive Quarto kernel status icon from session RuntimeState

d10cc67

Add useNotebookRuntimeSession hook

3cecb65

Drive notebook kernel status icon from session RuntimeState

5eccabc

dhruvisompura marked this pull request as ready for review May 6, 2026 16:44

dhruvisompura requested a review from seeM May 6, 2026 16:44

seeM reviewed May 7, 2026

View reviewed changes

dhruvisompura added 6 commits May 7, 2026 10:52

Fix Quarto badge flash during startup and restore vitest reference di…

ecbf86a

…rectives

Drop regression annotations from test titles

ca1855e

dhruvisompura requested a review from seeM May 7, 2026 20:23

seeM previously approved these changes May 11, 2026

View reviewed changes

dhruvisompura added 2 commits May 13, 2026 10:34

Merge branch 'main' into feature/derive-runtime-status-from-session

7a6cc96

Change how e2e test verifies if notebook can be shutdown

5d0ae6c

dhruvisompura dismissed seeM’s stale review via 5d0ae6c May 18, 2026 17:56

dhruvisompura mentioned this pull request May 18, 2026

Unify runtime status icon during session restart, change kernel, etc #13568

Open

dhruvisompura merged commit 0442939 into main May 18, 2026
23 checks passed

dhruvisompura deleted the feature/derive-runtime-status-from-session branch May 18, 2026 23:35

github-actions Bot locked and limited conversation to collaborators May 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unify runtime status shown across UIs#13376

Unify runtime status shown across UIs#13376
dhruvisompura merged 14 commits into
mainfrom
feature/derive-runtime-status-from-session

dhruvisompura commented May 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 5, 2026 •

edited

Loading

Uh oh!

seeM left a comment

Uh oh!

Uh oh!

Uh oh!

seeM May 7, 2026

Uh oh!

dhruvisompura May 7, 2026

Uh oh!

seeM May 7, 2026

Uh oh!

dhruvisompura May 7, 2026 •

edited

Loading

Uh oh!

seeM May 7, 2026

Uh oh!

Uh oh!

seeM May 7, 2026

Uh oh!

seeM left a comment

Uh oh!

dhruvisompura commented May 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dhruvisompura commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots

Release Notes

New Features

Bug Fixes

Validation Steps

Uh oh!

github-actions Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seeM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

seeM May 7, 2026

Choose a reason for hiding this comment

Uh oh!

dhruvisompura May 7, 2026

Choose a reason for hiding this comment

Uh oh!

seeM May 7, 2026

Choose a reason for hiding this comment

Uh oh!

dhruvisompura May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

seeM May 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

seeM May 7, 2026

Choose a reason for hiding this comment

Uh oh!

seeM left a comment

Choose a reason for hiding this comment

Uh oh!

dhruvisompura commented May 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dhruvisompura commented May 5, 2026 •

edited

Loading

github-actions Bot commented May 5, 2026 •

edited

Loading

dhruvisompura May 7, 2026 •

edited

Loading