feat: animate notebook cell execution footer expand/collapse#12946
Merged
feat: animate notebook cell execution footer expand/collapse#12946
Conversation
Hide the cell execution footer when a cell has never been run or was only run in a previous session. The footer collapses with a CSS transition (height, opacity, borders) and expands when the cell is queued or executed. Respects prefers-reduced-motion by disabling transitions. ARIA labels are suppressed on collapsed footers (via aria-hidden) and reordered so active states (running/pending) take priority over static states.
|
E2E Tests 🚀 |
dhruvisompura
previously approved these changes
Apr 13, 2026
Contributor
dhruvisompura
left a comment
dhruvisompura
left a comment
There was a problem hiding this comment.
Works as described on the tin! Not having the execution footer on cells is so much cleaner! Had a minor suggestion on code readability but not a blocker.
| aria-label={isCollapsed ? undefined : getAriaLabel()} | ||
| aria-live={isCurrentlyRunning ? 'polite' : 'off'} | ||
| className='positron-notebook-code-cell-footer' | ||
| className={`positron-notebook-code-cell-footer${isCollapsed ? ' collapsed' : ''}`} |
Contributor
There was a problem hiding this comment.
I would use positronClassNames here to improve the readability!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #11775
Hide the cell execution footer when a cell has never been run or was only run in a previous session. The footer collapses with a CSS transition (height, opacity, borders) and expands when the cell is queued or executed.
Demo
The execution info smoothly slides in and out as the info is available.
hiding-footer.mov
prefers-reduced-motionby disabling transitionsaria-hiddenPerformance
In theory this could be a performance issue with really large notebooks because the animation triggers a reflow of lower cells. In practice, it's not bad as if a cell has no output it's not normally followed by a bunch of cells with outputs. Also the animations are all done with CSS so they're fairly optimized. I tested with a notebook with ~100 cells and didnt notice any real performance issues but we can/should keep an eye on it.
Release Notes
New Features
Bug Fixes
QA Notes
@:notebooks @:positron-notebooks