Skip to content

Use plus icon for notebook add cell buttons#12948

Merged
nstrayer merged 2 commits intomainfrom
positron-nb-add-cell-button-refresh
Apr 14, 2026
Merged

Use plus icon for notebook add cell buttons#12948
nstrayer merged 2 commits intomainfrom
positron-nb-add-cell-button-refresh

Conversation

@nstrayer
Copy link
Copy Markdown
Contributor

@nstrayer nstrayer commented Apr 10, 2026

Partially addresses #11775

Summary

  • Replace code/markdown icons with plus icons on the between-cell add cell buttons
image

Old

image

QA Notes

Open a notebook with multiple cells. Hover between cells and verify the add cell buttons show a "+" icon instead of the old code/markdown icons.

Replace the code and markdown icons with plus icons on the
between-cell add cell buttons in Positron notebooks.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 10, 2026

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@nstrayer nstrayer requested review from dhruvisompura and seeM April 10, 2026 01:10
@seeM
Copy link
Copy Markdown
Contributor

seeM commented Apr 10, 2026

Super nit: I feel like it looks better in the example image from the issue. I think in theirs, the height of the plus matches the text height, and the horizontal line in the plus is more centered with the text (text is lifted a few pixels up?).

image

dhruvisompura
dhruvisompura previously approved these changes Apr 13, 2026
@nstrayer
Copy link
Copy Markdown
Contributor Author

@seeM agreed. This is because the codicon is not fully centered it appears.
image
I'll tweak it a bit to make it lineup

@nstrayer nstrayer merged commit e11ed79 into main Apr 14, 2026
19 checks passed
@nstrayer nstrayer deleted the positron-nb-add-cell-button-refresh branch April 14, 2026 01:53
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants