Fix LSP connection error notification on restart#13846
Merged
Merged
Conversation
|
E2E Tests 🚀 |
62e476d to
cb70032
Compare
Contributor
|
@lionel- i just unskipped the test and added the web test tag in PR description to either confirm or deny the test is happy. 🤞 |
Member
|
@lionel-, I'm pulling this change into my branch and will see if my (unskipped) test is happy as well. Thank you! |
Contributor
Author
|
Upstream fix: microsoft/vscode-languageserver-node#1782 |
DavisVaughan
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7593
@midleman @rodrigosf672 Could you please see if this branch fixes your skipped tests?
I think the notification is due to our
closed()handler (positron/extensions/positron-r/src/error-handler.ts
Lines 40 to 43 in a767974
handledto true.To work around this, we hook into the client's
errorhandler to manually ignore these errors.Release Notes
New Features
Bug Fixes
Validation Steps
Verified manually on my Linux laptop.
@:ark @:web