-
Notifications
You must be signed in to change notification settings - Fork 165
Add a Posit Connect pins driver to the Data Connections pane #14874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juliasilge
wants to merge
17
commits into
main
Choose a base branch
from
feat/data-connections-pins
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
947b169
Start new driver for pins
juliasilge c1fd4fc
Let's try treating pins as its own type of thing
juliasilge a106cfa
Scaffold out new driver extension for pins
juliasilge d8ce2b7
Let's also use a custom "owner" node kind
juliasilge 3df4de4
Use new node kind
juliasilge 59a2ead
Test URL handling
juliasilge 27a4432
Improve logging for pins support
juliasilge 1a0fe7d
Fix API key handling
juliasilge 82f093a
Sketch out some basic E2E testing
juliasilge 2968727
Remove some of these silly tests
juliasilge e749e44
Retry after fetch failures instead of caching rejections
juliasilge 9155f07
Hmmmm, no more cache here
juliasilge dddd15f
Clarify comment
juliasilge 2a92213
Update test tag mapping
juliasilge ba6f8af
Remove original scaffolding test
juliasilge 5c66ef2
Only cache fetch promise in `getPinType`
juliasilge 6581e1a
Hmmmm, let's actually run these tests
juliasilge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| /*--------------------------------------------------------------------------------------------- | ||
| * Copyright (C) 2026 Posit Software, PBC. All rights reserved. | ||
| * Licensed under the Elastic License 2.0. See LICENSE.txt for license information. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
| import * as path from 'node:path'; | ||
| import { run } from '../esbuild-extension-common.mts'; | ||
|
|
||
| const srcDir = path.join(import.meta.dirname, 'src'); | ||
| const outDir = path.join(import.meta.dirname, 'dist'); | ||
|
|
||
| run({ | ||
| platform: 'node', | ||
| entryPoints: { | ||
| 'extension': path.join(srcDir, 'extension.ts'), | ||
| }, | ||
| srcDir, | ||
| outdir: outDir, | ||
| additionalOptions: { | ||
| external: ['vscode', 'positron'], | ||
| }, | ||
| }, process.argv); |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the Connect logo here, so now the dialog to set up a Connection looks like this: