fix(pwb-local): properly wire --credentials flag and show it in install/status output#14880
Merged
Conversation
--credentials=<type> was never wired into the top-level dispatcher and always failed with "Unknown subcommand". Also surfaces the configured credential type in the install summary and status output, only when configure-datasources.sh actually succeeds.
|
E2E Tests 🚀 Why these tags?
More on automatic tags from changed files. |
Matches the naming used by the sibling wb-local README and drops redundant self-reference to the containing directory's own name.
workbench-dev implied a debugging/breakpoint setup that this stack doesn't provide; pwb-local matches the npm run pwb command and the naming convention of sibling *-local directories.
midleman
changed the title
log_error was appending this informational message to ERRORS[], triggering a spurious "N error(s) occurred" warning in the install summary even though nothing actually failed.
testlabauto
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
--credentialsflag fornpm run pwband cleans up naming in the workbench-dev environment.--credentials=<type>into the dispatcher (previously "Unknown subcommand")docker/environments/workbench-devtopwb-localREADME.md@:workbench