Skip to content

e2e: fix reticulate multi-session race by explicitly selecting session#14902

Merged
midleman merged 1 commit into
mainfrom
mi/reticulate-multi-session-focus
Jul 16, 2026
Merged

e2e: fix reticulate multi-session race by explicitly selecting session#14902
midleman merged 1 commit into
mainfrom
mi/reticulate-multi-session-focus

Conversation

@midleman

Copy link
Copy Markdown
Contributor

Summary

Fixes an intermittent race in the reticulate multi-session e2e test where code could execute against the wrong Python session.

  • console.executeCode() resolves its target by foreground/MRU session per language, not by session id
  • With two concurrent reticulate Python sessions, code could silently land in the non-visible session, failing the Variables pane check
  • Explicitly select the intended session (sessions.select()) before executing code in verifyReticulateFunctionality
  • Restores a step dropped in the e2e: improve stability of reticulate tests #10887 stability refactor
  • Root-caused via /triage-e2e-test; repro'd locally by running both reticulate specs concurrently (2/4 failures unfixed, 8/8 passing fixed)

QA Notes

@:reticulate @:web @:ark

…n before executing code

console.executeCode() resolves its target session by foreground/MRU
per-language, not by session id. With two concurrent reticulate Python
sessions, code could land in the wrong (non-visible) session, making
the Variables pane checks race intermittently. Explicitly select the
intended session before executing code, restoring behavior dropped in
the #10887 stability refactor.
@github-actions

Copy link
Copy Markdown

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:reticulate @:web @:ark

Why these tags?
Tag Source
@:critical Always runs (required)
@:reticulate PR description
@:web PR description
@:ark PR description

More on automatic tags from changed files.

readme  valid tags

@midleman
midleman merged commit ac514d8 into main Jul 16, 2026
26 checks passed
@midleman
midleman deleted the mi/reticulate-multi-session-focus branch July 16, 2026 13:48
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants