e2e: verify session tab click landed before reading metadata#14903
Open
midleman wants to merge 1 commit into
Open
e2e: verify session tab click landed before reading metadata#14903midleman wants to merge 1 commit into
midleman wants to merge 1 commit into
Conversation
A notification toast can sit on top of a console tab and swallow a force-click without the tab ever going active, leaving activePositronConsoleInstance stale so the metadata dialog silently never opens. Retry the click until the tab actually reports active.
|
E2E Tests 🚀 Why these tags?
More on automatic tags from changed files. Warning Unrecognized tag(s) in the PR description, ignored: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a flaky session-reuse path in e2e tests where a notification toast could swallow a force-click on a console tab, leaving the metadata dialog stuck closed.
Sessions.getMetadata()now retries the tab click until the tab actually reports active (tab-button--active), instead of assuming a force-click landed.@:triage-e2e-test: CI history showed this hitting the Quarto inline-output interactive-HTML-widget test almost exclusively on win/electron, correlating with concurrent notification toasts in sibling failures from the same runs.QA Notes
@:sessions @:win