Add SMTP authentication support for globally configured relay servers#3555
Open
adepretis wants to merge 2 commits intopostalserver:mainfrom
Open
Add SMTP authentication support for globally configured relay servers#3555adepretis wants to merge 2 commits intopostalserver:mainfrom
adepretis wants to merge 2 commits intopostalserver:mainfrom
Conversation
Author
|
@adamcooke any comment? |
Author
|
Anyone? - @willpower232 maybe? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds SMTP authentication support for globally configured relay servers in
postal.smtp_relays.Postal already supports relay entries like:
With this change, relay URLs can also include SMTP credentials:
When credentials are present, Postal connects to the relay using SMTP
LOGINauthentication. When they are not present, behavior remains unchanged.What changed
lib/postal/config_schema.rbto extract:usernamepasswordSMTPClient::Serverto carry optional relay credentials.SMTPSender.smtp_relaysto pass parsed credentials through to the SMTP client layer.SMTPClient::Endpoint#start_smtp_sessionto call:start(helo_hostname, username, password, :login)when credentials are configuredstart(helo_hostname)otherwiseSMTPSenderBackward compatibility
This is fully backward compatible for existing installations using unauthenticated relay URLs.
Notes
postal.smtp_relays.SMTPEndpointrecords or the UI.LOGINfor now.