Skip to content

Commit 26200a6

Browse files
committed
remove unused config settings
1 parent 5e33e0b commit 26200a6

File tree

6 files changed

+15
-32
lines changed

6 files changed

+15
-32
lines changed

NEWS.md

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ to:
1414

1515
```text
1616
V5: https://api.postcodeservice.com/nl/v5/find?zipcode=4201KB&houseno=63
17+
See https://developers-staging.postcodeservice.com/#netherlands-api
1718
```
1819

1920
- Added support for Belgium bilingual results in bilingual municipalities,
@@ -38,7 +39,7 @@ V3: https://api.postcodeservice.com/be/v3/zipcode-find?zipcodezone=1050&multires
3839
"city": "Bruxelles",
3940
"latitude": 50.8222854,
4041
"longitude": 4.3815707
41-
}
42+
},
4243
...
4344
]
4445
```
@@ -92,7 +93,8 @@ if (data.error_code) {
9293
- Revised and updated the Magento User manual to ensure it matches the latest changes.
9394
- Updated `SECURITY.md` with GitHub’s private reporting option, providing a secure channel for issue
9495
reporting.
95-
- Successfully tested the extension with the new Magento 2.4.7-beta1, Magento 2.4.7-beta2, confirming compatibility and
96+
- Successfully tested the extension with the new Magento 2.4.7-beta1, Magento 2.4.7-beta2,
97+
confirming compatibility and
9698
performance.
9799

98100
## UX/UC improvements
@@ -102,13 +104,14 @@ if (data.error_code) {
102104
in `postcode-nl.js`,
103105
see comment `// The last parameter is the delay in millisecond` in the file.
104106
- Similarly, decreased the loading speed of the address results for Belgium from 500 milliseconds to
105-
50 milliseconds for
107+
30 milliseconds for
106108
streets and 30 milliseconds for zipcodes by default. This can be changed in `postcode-be.js`, see
107109
twice
108110
the comment `// Parameter for the results delay in milliseconds`.
109111
- Eliminated the redundant loading screen for Nederlands in Magento Checkout, enhancing the overall
110112
user experience in the vanilla Magento Luma checkout theme. You can still turn this on in the
111-
file `postcode-api.js` in the method `getPostCodeNL` by setting the variable `showLoader: false` to `true`.
113+
file `postcode-api.js` in the method `getPostCodeNL` by setting the variable `showLoader: false`
114+
to `true`.
112115
- Deactivated advanced settings that were not being utilized, thereby simplifying the user
113116
interface.
114117
- Added new documentation links from within the extension to the Magento User manual and underlying
@@ -144,5 +147,6 @@ if (data.error_code) {
144147

145148
## Release credits
146149

147-
- Thanks go out to the following people for contributing to this release: Robert, Tim S., Vincent, Erik de
148-
Groot, Viktoriia and Peter S.
150+
- Thanks go out to the following people for contributing to this release: Robert, Tim S., Vincent,
151+
Erik de
152+
Groot, Viktoria and Peter S.

Plugin/Model/Checkout/LayoutProcessorPlugin.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -249,12 +249,6 @@ public function afterProcess($subject, $jsLayout) {
249249
// @TODO use a better way to set sort order for postcode field,
250250
// tried in branch "tryout_billing_address_sortorder_mixin"
251251

252-
// @TODO remove debug data
253-
/* $file = fopen('test.txt', 'a+');
254-
fwrite($file, $defaultCountry . "--");
255-
fclose($file);
256-
*/
257-
258252
if ($defaultCountry === "NL" || $defaultCountry === "BE" || $defaultCountry === "DE") {
259253
$jsLayout = $this->arrayManager->set($postalCodePath . '/config/sortOrder', $jsLayout, 50);
260254
}

composer.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,14 @@
1313
{
1414
"name": "TIG",
1515
"email": "support@postcodeservice.com",
16-
"homepage": "https://postcodeservice.nl/"
16+
"homepage": "https://postcodeservice.com"
1717
}
1818
],
1919
"support": {
2020
"email": "support@postcodeservice.com",
21-
"issues": "https://portal.tig.nl"
21+
"issues": "https://postcodeservice.com/support/"
2222
},
23-
"homepage": "https://postcodeservice.nl/",
23+
"homepage": "https://postcodeservice.com",
2424
"minimum-stability": "RC",
2525
"autoload": {
2626
"files": [

etc/config.xml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -64,21 +64,6 @@
6464
<enable_be_check>1</enable_be_check>
6565
<enable_de_check>1</enable_de_check>
6666
</countries>
67-
<search_nl>
68-
<results_delay_in_ms>30</results_delay_in_ms>
69-
</search_nl>
70-
<search_be>
71-
<zipcode_results_delay_in_ms>30</zipcode_results_delay_in_ms>
72-
<zipcode_results_max>8</zipcode_results_max>
73-
<street_results_delay_in_ms>50</street_results_delay_in_ms>
74-
<street_results_max>6</street_results_max>
75-
</search_be>
76-
<search_de>
77-
<zipcode_results_delay_in_ms>30</zipcode_results_delay_in_ms>
78-
<zipcode_results_max>8</zipcode_results_max>
79-
<street_results_delay_in_ms>50</street_results_delay_in_ms>
80-
<street_results_max>6</street_results_max>
81-
</search_de>
8267
</tig_postcode>
8368
</default>
8469
</config>

view/base/web/js/postcode-handler/postcode-be.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ define(
214214
streetField.attr('autocomplete', 'yes');
215215

216216
streetField.autocomplete({
217-
delay: 50, // Parameter for the results delay in milliseconds
217+
delay: 30, // Parameter for the results delay in milliseconds
218218
source: function (street, response) {
219219
var postcode = currentPostcodeService.getElement(FieldTypes.postcode).value();
220220
var city = currentPostcodeService.getElement(FieldTypes.city).value();

view/base/web/js/postcode-handler/postcode-de.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ define(
214214
streetField.attr('autocomplete', 'yes');
215215

216216
streetField.autocomplete({
217-
delay: 50, // Parameter for the results delay in milliseconds
217+
delay: 30, // Parameter for the results delay in milliseconds
218218
source: function (street, response) {
219219
var postcode = currentPostcodeService.getElement(FieldTypes.postcode).value();
220220
var city = currentPostcodeService.getElement(FieldTypes.city).value();

0 commit comments

Comments
 (0)