ci: remove disabled CircleCI config#451
Open
Komzpa wants to merge 2 commits into
Open
Conversation
Signed-off-by: Darafei Praliaskouski <me@komzpa.net>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Signed-off-by: Darafei Praliaskouski <me@komzpa.net>
Member
|
Master branch passed those builds, dunno why the second commit would be needed here, maybe it isn't ? Or at least shouldn't be in this PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.circleci/config.ymlplaceholdernlohmann/jsonsource version used by master images instead of querying GitHub's latest-release API during Docker buildsWhy
Issue #450 reports CI fallout after CircleCI builds were disabled. The current placeholder config is still enough for CircleCI to start a pipeline, but it errors before creating any jobs:
https://app.circleci.com/pipelines/gh/postgis/docker-postgis/48
The first GitHub Actions run on this branch then exposed a separate master-image CI failure in
16-master-default ubuntu-24.04: the GitHub API lookup fornlohmann/jsonreturned notag_name, leavingNLOHMANN_JSON_VERSIONempty and making the build downloadv.tar.gz.https://github.com/postgis/docker-postgis/actions/runs/26637060793/job/78499968937
Pinning the version keeps these Docker builds deterministic and avoids anonymous API/rate-limit behavior in CI.
Validation
git diff --checkruby -e 'require "yaml"; YAML.load_file(".github/workflows/main.yml"); puts "workflow yaml ok"'bash -n update.sh ci/matrix.sh ci/test-image.sh ci/push-manifest.sh ci/prepare-dockerhub-readme.shgh api repos/postgis/docker-postgis/commits/57874f98352405d7da7ff5c5ddebb47bc3339dcf/statusshows no CircleCI failure status on this branch headCloses #450