fix(platform): guard nil recognized_org in billing usage response

Author: Sarumyan

engine/pkg/client/platform/client_test.go

@@ -14,6 +14,8 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"gitlab.com/postgres-ai/database-lab/v3/pkg/config/global"
 )
 
 // roundTripFunc represents a mock type.
@@ -191,3 +193,52 @@ func TestClientChecksPlatformTokenFailed(t *testing.T) {
 	assert.Equal(t, expectedResponse.APIResponse.Hint, platformToken.Hint)
 	assert.Equal(t, expectedResponse.APIResponse.Details, platformToken.Details)
 }
+
+func TestClientSendUsage(t *testing.T) {
+	testCases := []struct {
+		name            string
+		response        BillingResponse
+		wantBillingPage string
+	}{
+		{name: "response without recognized org", response: BillingResponse{Result: "ok", BillingActive: true}},
+		{name: "response with recognized org", response: BillingResponse{Result: "ok", BillingActive: true, Org: &Org{ID: 1, Alias: "acme"}},
+			wantBillingPage: "https://example.com/console/acme/billing"},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			testClient := NewTestClient(func(req *http.Request) *http.Response {
+				body, err := json.Marshal(EditionResponse{BillingResponse: tc.response})
+				require.NoError(t, err)
+
+				return &http.Response{
+					StatusCode: http.StatusOK,
+					Body:       io.NopCloser(bytes.NewBuffer(body)),
+				}
+			})
+
+			platformClient, err := NewClient(ClientConfig{
+				URL:         "https://example.com/",
+				AccessToken: "testVerify",
+				OrgKey:      "testOrgKey",
+			})
+			require.NoError(t, err)
+			platformClient.client = testClient
+
+			props := &global.EngineProps{}
+			respData, err := platformClient.SendUsage(context.Background(), props, InstanceUsage{InstanceID: "test"})
+			require.NoError(t, err)
+
+			assert.True(t, respData.BillingActive)
+			assert.True(t, props.BillingActive)
+
+			if tc.wantBillingPage == "" {
+				assert.Nil(t, respData.Org)
+				return
+			}
+
+			require.NotNil(t, respData.Org)
+			assert.Equal(t, tc.wantBillingPage, respData.Org.BillingPage)
+		})
+	}
+}

engine/pkg/client/platform/telemetry.go

@@ -147,11 +147,15 @@ func (p *Client) SendUsage(ctx context.Context, props *global.EngineProps, usage
 		log.Dbg("Instance state updated. Billing is active:", respData.BillingActive)
 	}
 
-	respData.Org.BillingPage = (&url.URL{
-		Scheme: p.url.Scheme,
-		Host:   p.url.Host,
-		Path:   path.Join(consolePath, respData.Org.Alias, billingPath),
-	}).String()
+	// the org is optional in the response ("recognized_org,omitempty"); build the billing
+	// page URL only when the platform recognized the organization
+	if respData.Org != nil {
+		respData.Org.BillingPage = (&url.URL{
+			Scheme: p.url.Scheme,
+			Host:   p.url.Host,
+			Path:   path.Join(consolePath, respData.Org.Alias, billingPath),
+		}).String()
+	}
 
 	log.Dbg("Usage event response", respData)