fix(cli): address low priority code quality issues

- Remove trailing blank lines from checkup-api.ts
- Add comment explaining backend typo workaround (report_chunck_id)
- Handle negative bytes and NaN/Infinity in formatBytes
- Add unit index bounds check to prevent array overflow
- Add tests for formatBytes edge cases

Author: NikolayS

cli/lib/checkup-api.ts

@@ -275,11 +275,10 @@ export async function uploadCheckupReportJson(params: {
     rpcName: "checkup_report_file_post",
     bodyObj,
   });
+  // Backend has a typo: "report_chunck_id" (with 'ck') - handle both spellings for compatibility
   const chunkId = Number(resp?.report_chunck_id ?? resp?.report_chunk_id);
   if (!Number.isFinite(chunkId) || chunkId <= 0) {
     throw new Error(`Unexpected checkup_report_file_post response: ${JSON.stringify(resp)}`);
   }
   return { reportChunkId: chunkId };
 }
-
-

cli/lib/checkup.ts

@@ -209,8 +209,10 @@ export function parseVersionNum(versionNum: string): { major: string; minor: str
  */
 export function formatBytes(bytes: number): string {
   if (bytes === 0) return "0 B";
+  if (bytes < 0) return `-${formatBytes(-bytes)}`; // Handle negative values
+  if (!Number.isFinite(bytes)) return `${bytes} B`; // Handle NaN/Infinity
   const units = ["B", "KiB", "MiB", "GiB", "TiB", "PiB"];
-  const i = Math.floor(Math.log(bytes) / Math.log(1024));
+  const i = Math.min(Math.floor(Math.log(bytes) / Math.log(1024)), units.length - 1);
   return `${(bytes / Math.pow(1024, i)).toFixed(2)} ${units[i]}`;
 }
 

cli/test/checkup.test.ts

@@ -331,6 +331,16 @@ describe("formatBytes", () => {
   test("formats gibibytes", () => {
     expect(checkup.formatBytes(1073741824)).toBe("1.00 GiB");
   });
+
+  test("handles negative bytes", () => {
+    expect(checkup.formatBytes(-1024)).toBe("-1.00 KiB");
+    expect(checkup.formatBytes(-1048576)).toBe("-1.00 MiB");
+  });
+
+  test("handles edge cases", () => {
+    expect(checkup.formatBytes(NaN)).toBe("NaN B");
+    expect(checkup.formatBytes(Infinity)).toBe("Infinity B");
+  });
 });
 
 // Mock client tests for report generators