Get true lock_timeout and statement_timeout#8
Closed
NikolayS wants to merge 5 commits into
Closed
Conversation
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
pgwatch sets lock_timeout to 100ms during metric collection, which causes the monitoring to report 100ms instead of the actual configured value. This fix queries reset_val from pg_settings for lock_timeout to get the genuine configuration value. Closes #61
NikolayS
force-pushed
the
claude/implement-issue-61-C8E0c
branch
from
7891edc to
7893064
Compare
When pgwatch sets lock_timeout during collection, source becomes 'session', causing is_default to incorrectly report non-default. Now we compare reset_val with boot_val to determine the true default status for lock_timeout.
NikolayS
changed the title
pgwatch sets statement_timeout per-metric during collection, which would mask the actual configured value. Apply the same reset_val fix as lock_timeout.
Contributor
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pgwatch sets lock_timeout to 100ms during metric collection, which causes the monitoring to report 100ms instead of the actual configured value. This fix queries reset_val from pg_settings for lock_timeout to get the genuine configuration value.
Closes #61
Note
Ensures the
settingsmetric reports actual configured values instead of session overrides.metrics.ymlsettingsSQL: usereset_valforlock_timeout/statement_timeout, derivenumeric_valuefrom the same source, and computeis_defaultby comparingreset_valtoboot_val; description updated to document behaviortests/settings/: unit tests validating SQL fields/logic and description, plus an integration test confirminglock_timeoutreturns the reset (configured) value even when session overrides are appliedWritten by Cursor Bugbot for commit fb693bf. Configure here.