Default to sending emails for patches where you are the author

This only applies to new users or users that never clicked the profile
button.

Author: JelteF

pgcommitfest/commitfest/models.py

@@ -202,11 +202,13 @@ def send_closure_notifications(self):
         # Send email to each author who has notifications enabled
         for author, patches in authors_patches.items():
             try:
-                if not author.userprofile.notify_all_author:
+                profile = author.userprofile
+                if not profile.notify_all_author:
                     continue
-                notifyemail = author.userprofile.notifyemail
+                notifyemail = profile.notifyemail
             except UserProfile.DoesNotExist:
-                continue
+                # No profile means use default (notify=True), so continue
+                notifyemail = None
 
             email = notifyemail.email if notifyemail else author.email
 
@@ -813,9 +815,12 @@ def save_and_notify(
                     )
                 )
 
-        # Current or previous authors wants all notifications
+        # Current or previous authors wants all notifications (default is True,
+        # so include users without a profile)
         recipients.extend(
-            self.patch.authors.filter(userprofile__notify_all_author=True)
+            self.patch.authors.filter(
+                Q(userprofile__isnull=True) | Q(userprofile__notify_all_author=True)
+            )
         )
 
         for u in set(recipients):

pgcommitfest/commitfest/templates/mail/commitfest_closure.txt

@@ -12,3 +12,8 @@ Please take action on {{patches|length|pluralize:"these patches,this patch"}} by
 1. If you want to continue working on {{patches|length|pluralize:"them,it"}}, move {{patches|length|pluralize:"them,it"}} to the next commitfest.
 
 2. If you no longer wish to pursue {{patches|length|pluralize:"these patches,this patch"}}, please close {{patches|length|pluralize:"them,it"}} with an appropriate status (Withdrawn, Returned with feedback, etc.)
+
+--
+This is an automated message from the PostgreSQL Commitfest app.
+To manage your notification preferences, visit:
+https://commitfest.postgresql.org/userprofile/

pgcommitfest/commitfest/templates/mail/patch_notify.txt

@@ -9,3 +9,7 @@ https://commitfest.postgresql.org/patch/{{p.patch.id}}/
 
 
 {%endfor%}
+--
+This is an automated message from the PostgreSQL Commitfest app.
+To manage your notification preferences, visit:
+https://commitfest.postgresql.org/userprofile/

pgcommitfest/commitfest/tests/conftest.py

@@ -12,14 +12,14 @@
 
 @pytest.fixture
 def alice():
-    """Create test user Alice with notify_all_author enabled."""
+    """Create test user Alice with a profile (uses default notify_all_author=True)."""
     user = User.objects.create_user(
         username="alice",
         first_name="Alice",
         last_name="Anderson",
         email="alice@example.com",
     )
-    UserProfile.objects.create(user=user, notify_all_author=True)
+    UserProfile.objects.create(user=user)
     return user
 
 

pgcommitfest/commitfest/tests/test_closure_notifications.py

@@ -119,10 +119,7 @@ def test_one_email_per_author_with_multiple_patches(alice, in_progress_cf):
 
 
 def test_multiple_authors_receive_separate_emails(alice, bob, in_progress_cf):
-    """Each author of open patches should receive their own notification (if opted in)."""
-    # Bob also needs notify_all_author enabled to receive closure emails
-    UserProfile.objects.create(user=bob, notify_all_author=True)
-
+    """Each author of open patches should receive their own notification."""
     patch1 = Patch.objects.create(name="Alice Patch")
     patch1.authors.add(alice)
     PatchOnCommitFest.objects.create(
@@ -149,10 +146,7 @@ def test_multiple_authors_receive_separate_emails(alice, bob, in_progress_cf):
 
 
 def test_coauthors_both_receive_notification(alice, bob, in_progress_cf):
-    """Both co-authors of a patch should receive notifications (if opted in)."""
-    # Bob also needs notify_all_author enabled to receive closure emails
-    UserProfile.objects.create(user=bob, notify_all_author=True)
-
+    """Both co-authors of a patch should receive notifications."""
     patch = Patch.objects.create(name="Coauthored Patch")
     patch.authors.add(alice)
     patch.authors.add(bob)
@@ -170,9 +164,9 @@ def test_coauthors_both_receive_notification(alice, bob, in_progress_cf):
     assert receivers == {alice.email, bob.email}
 
 
-def test_no_notification_for_author_without_notify_all_author(bob, in_progress_cf):
-    """Authors without notify_all_author enabled should not receive closure notifications."""
-    # bob has no UserProfile, so notify_all_author is not enabled
+def test_no_notification_for_author_who_opted_out(bob, in_progress_cf):
+    """Authors who explicitly opted out should not receive closure notifications."""
+    UserProfile.objects.create(user=bob, notify_all_author=False)
     patch = Patch.objects.create(name="Test Patch")
     patch.authors.add(bob)
     PatchOnCommitFest.objects.create(
@@ -187,6 +181,24 @@ def test_no_notification_for_author_without_notify_all_author(bob, in_progress_c
     assert QueuedMail.objects.count() == 0
 
 
+def test_notification_for_author_without_profile(bob, in_progress_cf):
+    """Authors without a UserProfile should receive notifications (opt-out default)."""
+    patch = Patch.objects.create(name="Test Patch")
+    patch.authors.add(bob)
+    PatchOnCommitFest.objects.create(
+        patch=patch,
+        commitfest=in_progress_cf,
+        enterdate=datetime.now(),
+        status=PatchOnCommitFest.STATUS_REVIEW,
+    )
+
+    in_progress_cf.send_closure_notifications()
+
+    assert QueuedMail.objects.count() == 1
+    mail = QueuedMail.objects.first()
+    assert mail.receiver == bob.email
+
+
 # Auto-move tests
 
 

pgcommitfest/userprofile/models.py

@@ -36,7 +36,7 @@ class UserProfile(models.Model):
     notify_all_author = models.BooleanField(
         null=False,
         blank=False,
-        default=False,
+        default=True,
         verbose_name="Notify on all where author",
     )
     notify_all_reviewer = models.BooleanField(