fix: RemoteOperations::exec_command passes exec_env incorrectly (#11)

When we pass exec_env, we expect that they will be available within nested applications but it does not happen.

The reason is in incorrect commands for setting environment variables - "name1=value1;name2=value2;<command>".

We have to use "export name1=value1;export name2=value2;<command>".

The new test "test_exec_command_with_exec_env__2" is added. It fails on old implementation and works fine on the new one.

Author: dmitry-lipetsk

src/remote_ops.py

@@ -832,7 +832,7 @@ def _create_exec_env_list(exec_env: typing.Dict) -> typing.List[str]:
                 assert type(envvar[1]) == str  # noqa: E721
                 qvalue = __class__._quote_envvar(envvar[1])
                 assert type(qvalue) == str  # noqa: E721
-                result.append(envvar[0] + "=" + qvalue)
+                result.append("export " + envvar[0] + "=" + qvalue)
             continue
 
         return result

tests/test_os_ops_common.py

@@ -130,6 +130,44 @@ def test_exec_command_with_exec_env(self, os_ops: OsOperations):
         assert type(response) == bytes  # noqa: E721
         assert response == b'\n'
 
+    def test_exec_command_with_exec_env__2(self, os_ops: OsOperations):
+        assert isinstance(os_ops, OsOperations)
+
+        RunConditions.skip_if_windows()
+
+        C_ENV_NAME = "TESTGRES_TEST__EXEC_ENV_20250414"
+
+        tmp_file_content = "echo ${{{}}}".format(C_ENV_NAME)
+
+        logging.info("content is [{}]".format(tmp_file_content))
+
+        tmp_file = os_ops.mkstemp()
+        assert type(tmp_file) == str  # noqa: E721
+        assert tmp_file != ""
+
+        logging.info("file is [{}]".format(tmp_file))
+        assert os_ops.path_exists(tmp_file)
+
+        os_ops.write(tmp_file, tmp_file_content)
+
+        cmd = ["sh", tmp_file]
+
+        exec_env = {C_ENV_NAME: "Hello!"}
+
+        response = os_ops.exec_command(cmd, exec_env=exec_env)
+        assert response is not None
+        assert type(response) == bytes  # noqa: E721
+        assert response == b'Hello!\n'
+
+        response = os_ops.exec_command(cmd)
+        assert response is not None
+        assert type(response) == bytes  # noqa: E721
+        assert response == b'\n'
+
+        os_ops.remove_file(tmp_file)
+        assert not os_ops.path_exists(tmp_file)
+        return
+
     def test_exec_command_with_cwd(self, os_ops: OsOperations):
         assert isinstance(os_ops, OsOperations)