CI: Verification with ruff is added (#29)

* A ruff-problems are fixed

* LocalOperations: a call of subprocess.Popen is fixed (typing.Dict[str, typing.Any])

* CI: Verification with ruff is added

Author: dmitry-lipetsk

.github/workflows/package-verification.yml

@@ -27,10 +27,13 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
-        python -m pip install flake8 flake8-pyproject
+        python -m pip install flake8 flake8-pyproject ruff
     - name: Lint with flake8
       run: |
         flake8 .
+    - name: Lint with ruff
+      run: |
+        ruff check .
 
   test:
     runs-on: ubuntu-latest

src/local_ops.py

@@ -107,7 +107,7 @@ def _run_command__nt(
 
         # TODO: why don't we use the data from input?
 
-        extParams: typing.Dict[str, str] = dict()
+        extParams: typing.Dict[str, typing.Any] = dict()
 
         if exec_env is None:
             pass
@@ -166,7 +166,7 @@ def _run_command__generic(
 
         assert input_prepared is None or type(input_prepared) is bytes
 
-        extParams: typing.Dict[str, str] = dict()
+        extParams: typing.Dict[str, typing.Any] = dict()
 
         if exec_env is None:
             pass
@@ -198,7 +198,7 @@ def _run_command__generic(
             cwd=cwd,
             **extParams
         )
-        assert not (process is None)
+        assert process is not None
         if get_process:
             return process, None, None
         try:

src/remote_ops.py

@@ -140,7 +140,7 @@ def exec_command(
         ssh_cmd = ['ssh', self.ssh_dest] + self.ssh_args + [cmdline]
 
         process = subprocess.Popen(ssh_cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-        assert not (process is None)
+        assert process is not None
         if get_process:
             return process
 

tests/test_os_ops_common.py

@@ -1014,7 +1014,7 @@ def LOG_INFO(template: str, *args) -> None:
             LOG_INFO("HELLO! I am here!")
 
             for num in range(cNumbers):
-                assert not (num in reservedNumbers)
+                assert num not in reservedNumbers
 
                 file_path = MAKE_PATH(lock_dir, num)
 
@@ -1150,7 +1150,7 @@ class tadWorkerData:
         logging.info("OK. Let's check reservedNumbers!")
 
         for n in range(N_NUMBERS):
-            if not (n in reservedNumbers.keys()):
+            if n not in reservedNumbers.keys():
                 nErrors += 1
                 logging.error("Number {} is not reserved!".format(n))
                 continue