Fix attributes not string

thewebartisan7 · thewebartisan7 · commit 346ae0525e94 · 2022-11-03T03:10:28.000+01:00
diff --git a/changelog.md b/changelog.md
@@ -1,3 +1,7 @@
+## 1.0.0-beta.14 (2022-11-03)
+
+* Fix node attributes not string
+
 ## 1.0.0-beta.13 (2022-11-03)
 
 * Remove attributes that have "undefined" or "null" value
diff --git a/docs-src/md/changelog.md b/docs-src/md/changelog.md
@@ -1,3 +1,7 @@
+## 1.0.0-beta.14 (2022-11-03)
+
+* Fix node attributes not string
+
 ## 1.0.0-beta.13 (2022-11-03)
 
 * Remove attributes that have "undefined" or "null" value
diff --git a/docs-src/pages/index.html b/docs-src/pages/index.html
@@ -14,7 +14,7 @@ <h1 class="display-1 fw-bold mb-4">Build the web with PostHTML</h1>
       </div>
 
       <p class="text-muted">
-        Currently <strong>v1.0.0-beta.13</strong>
+        Currently <strong>v1.0.0-beta.14</strong>
         <span class="px-1">·</span>
         <a href="#" class="link-secondary" data-bs-toggle="modal" data-bs-target="#modalWithComponents">Changelog</a>
       </p>
diff --git a/docs/demo.html b/docs/demo.html
@@ -77,6 +77,13 @@ <h5 class="modal-title" id="modalWithComponentsLabel">Changelog</h5>
           </div>
           <!-- /.modal-header -->
           <div class="modal-body">
+            <h2 id="1.0.0-beta.14-(2022-11-03)" tabindex="-1">
+              <a class="header-anchor" href="#1.0.0-beta.14-(2022-11-03)">#</a>
+              1.0.0-beta.14 (2022-11-03)
+            </h2>
+            <ul>
+              <li>Fix node attributes not string</li>
+            </ul>
             <h2 id="1.0.0-beta.13-(2022-11-03)" tabindex="-1">
               <a class="header-anchor" href="#1.0.0-beta.13-(2022-11-03)">#</a>
               1.0.0-beta.13 (2022-11-03)
diff --git a/docs/docs.html b/docs/docs.html
@@ -1488,6 +1488,13 @@ <h5 class="modal-title" id="modalWithComponentsLabel">Changelog</h5>
           </div>
           <!-- /.modal-header -->
           <div class="modal-body">
+            <h2 id="1.0.0-beta.14-(2022-11-03)" tabindex="-1">
+              <a class="header-anchor" href="#1.0.0-beta.14-(2022-11-03)">#</a>
+              1.0.0-beta.14 (2022-11-03)
+            </h2>
+            <ul>
+              <li>Fix node attributes not string</li>
+            </ul>
             <h2 id="1.0.0-beta.13-(2022-11-03)" tabindex="-1">
               <a class="header-anchor" href="#1.0.0-beta.13-(2022-11-03)">#</a>
               1.0.0-beta.13 (2022-11-03)
diff --git a/docs/index.html b/docs/index.html
@@ -59,7 +59,7 @@ <h1 class="display-1 fw-bold mb-4">Build the web with PostHTML</h1>
             </div>
             <p class="text-muted">
               Currently
-              <strong>v1.0.0-beta.13</strong>
+              <strong>v1.0.0-beta.14</strong>
               <span class="px-1">·</span>
               <a href="#" class="link-secondary" data-bs-toggle="modal" data-bs-target="#modalWithComponents">Changelog</a>
             </p>
@@ -93,6 +93,13 @@ <h5 class="modal-title" id="modalWithComponentsLabel">Changelog</h5>
           </div>
           <!-- /.modal-header -->
           <div class="modal-body">
+            <h2 id="1.0.0-beta.14-(2022-11-03)" tabindex="-1">
+              <a class="header-anchor" href="#1.0.0-beta.14-(2022-11-03)">#</a>
+              1.0.0-beta.14 (2022-11-03)
+            </h2>
+            <ul>
+              <li>Fix node attributes not string</li>
+            </ul>
             <h2 id="1.0.0-beta.13-(2022-11-03)" tabindex="-1">
               <a class="header-anchor" href="#1.0.0-beta.13-(2022-11-03)">#</a>
               1.0.0-beta.13 (2022-11-03)
diff --git a/docs/test.html b/docs/test.html
@@ -48,7 +48,7 @@
           <div class="col-lg-8">
             <h1 class="display-1 fw-bold mb-4">Playground</h1>
             <div class="wrapper">
-              <div class="demo my-demo" computed:acomputed="" something="alocal">
+              <div class="demo my-demo" computed:acomputed="true" something="alocal">
                 {"title":"PostHTML Components","close":true,"$slots":{},"aStringOverride":"My override string changed","anObjectOverride":{"third":"Third override item","fourth":"Fourth override item"},"computed:aComputed":true,"class":"my-demo","anObjectMerged":{"third":"Third merged item","fourth":"Fourth merged item","anObjectMerged1":{"third":"Third merged item (UPDATED?)","fourth1":"Fourth merged item"}},"post":{"title":"My post title","body":"My post body","comments":[{"id":1,"body":"My comment 1 new"},{"id":3,"body":"My comment 3"}]},"anArrayOfObjects":[{"id":1,"title":"My new title 1"},{"id":2,"title":"My new title 2","somethingnew":"New"}],"anArray":["first","third","fourth","ten"],"something":"alocal"}
                 <div>
                   <a href="/my-page.html">
@@ -221,6 +221,13 @@ <h5 class="modal-title" id="modalWithComponentsLabel">Changelog</h5>
           </div>
           <!-- /.modal-header -->
           <div class="modal-body">
+            <h2 id="1.0.0-beta.14-(2022-11-03)" tabindex="-1">
+              <a class="header-anchor" href="#1.0.0-beta.14-(2022-11-03)">#</a>
+              1.0.0-beta.14 (2022-11-03)
+            </h2>
+            <ul>
+              <li>Fix node attributes not string</li>
+            </ul>
             <h2 id="1.0.0-beta.13-(2022-11-03)" tabindex="-1">
               <a class="header-anchor" href="#1.0.0-beta.13-(2022-11-03)">#</a>
               1.0.0-beta.13 (2022-11-03)
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "posthtml-component",
-  "version": "1.0.0-beta.13",
+  "version": "1.0.0-beta.14",
   "description": "PostHTML Components Blade-like with slots, attributes as props and custom tag",
   "license": "MIT",
   "repository": "thewebartisan7/posthtml-components",
diff --git a/src/process-attributes.js b/src/process-attributes.js
@@ -9,6 +9,7 @@ const union = require('lodash/union');
 const each = require('lodash/each');
 const has = require('lodash/has');
 const extend = require('lodash/extend');
+const isString = require('lodash/isString');
 const isObject = require('lodash/isObject');
 
 /**
@@ -66,7 +67,7 @@ module.exports = (currentNode, attributes, props, options) => {
   each(nodeAttrs, (value, key) => {
     if (['undefined', 'null'].includes(value)) {
       delete nodeAttrs[key];
-    } else if (!isObject(nodeAttrs[key])) {
+    } else if (key !== 'compose' && !isObject(nodeAttrs[key]) && !isString(nodeAttrs[key])) {
       nodeAttrs[key] = nodeAttrs[key].toString();
     }
   });
diff --git a/test/test-attributes.js b/test/test-attributes.js
@@ -51,8 +51,8 @@ test('Must override class and style attributes', async t => {
 });
 
 test('Must remove an attributes that has "undefined" or "null" value', async t => {
-  const actual = `<component src="components/remove-attributes.html">My button</component>`;
-  const expected = `<button class="btn btn-primary" data-bs-dismiss="true" data-bs-backdrop="false">My button</button>`;
+  const actual = `<component src="components/remove-attributes.html" tabindex="-1">My button</component>`;
+  const expected = `<button class="btn btn-primary" data-bs-dismiss="true" data-bs-backdrop="false" tabindex="-1">My button</button>`;
 
   const html = await posthtml([plugin({root: './test/templates', tag: 'component'})]).process(actual).then(result => clean(result.html));
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "posthtml-component",`
`3`		`- "version": "1.0.0-beta.13",`
	`3`	`+ "version": "1.0.0-beta.14",`
`4`	`4`	`"description": "PostHTML Components Blade-like with slots, attributes as props and custom tag",`
`5`	`5`	`"license": "MIT",`
`6`	`6`	`"repository": "thewebartisan7/posthtml-components",`