Fix missing callback on early return in export-file.js#3356
Open
carterpewpew wants to merge 1 commit into
Open
Fix missing callback on early return in export-file.js#3356carterpewpew wants to merge 1 commit into
carterpewpew wants to merge 1 commit into
Conversation
The early return in lib/run/export-file.js when path validation fails did not invoke the done() callback, causing async.each in the run module to hang indefinitely. Now returns done() with an error describing the invalid export path, ensuring Newman always completes or reports a meaningful error instead of silently hanging. Signed-off-by: Jathavedhan M <jathavedhan.m@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
done()callback on early return inlib/run/export-file.jswhen path validation failsasync.eachin the run module hangs indefinitely, causing Newman to silently freezedone()with a descriptive error, ensuring Newman always completes or reports a meaningful errorTest plan
--export-environment,--export-globals, etc.) are unaffected/, or third-party reporters pushing exports without a valid path or default)