Fixed publish.

Author: gfraiteur

src/PostSharp.Engineering.BuildTools/Build/BuildCommand.cs

@@ -125,7 +125,7 @@ public static bool Execute( BuildContext context, BuildSettings settings )
             ImportFile.Delete( context );
 
             // We have to read the version from the file we have generated - using MSBuild, because it contains properties.
-            var buildInfo = BuildArguments.Read( context, settings.BuildConfiguration );
+            var buildInfo = BuildArguments.ReadFromArtifactManifest( context, settings.BuildConfiguration );
 
             var privateArtifactsDirectory = product.GetPrivateArtifactsAbsoluteDirectory( context, settings.BuildConfiguration );
 

src/PostSharp.Engineering.BuildTools/Build/Model/BuildArguments.cs

@@ -3,6 +3,7 @@
 using PostSharp.Engineering.BuildTools.Build.Files;
 using PostSharp.Engineering.BuildTools.Dependencies.Model;
 using System;
+using System.Diagnostics.CodeAnalysis;
 
 namespace PostSharp.Engineering.BuildTools.Build.Model
 {
@@ -24,7 +25,7 @@ internal BuildArguments( string? packageVersion, BuildConfiguration configuratio
             product.DependencyDefinition,
             packagePreviewVersion ) { }
 
-        internal BuildArguments(
+        private BuildArguments(
             string? packageVersion,
             BuildConfiguration configuration,
             DependencyDefinition dependencyDefinition,
@@ -34,7 +35,7 @@ internal BuildArguments(
             dependencyDefinition.MSBuildConfiguration[configuration],
             packagePreviewVersion ) { }
 
-        internal BuildArguments( string? packageVersion, string configuration, string msBuildConfiguration, string? packagePreviewVersion )
+        private BuildArguments( string? packageVersion, string configuration, string msBuildConfiguration, string? packagePreviewVersion )
         {
             this.PackageVersion = packageVersion;
             this.Configuration = configuration;
@@ -55,7 +56,33 @@ internal BuildArguments( string? packageVersion, string configuration, string ms
 
         public string? PackagePreviewVersion { get; init; }
 
-        public static BuildArguments Read( BuildContext context, BuildConfiguration buildConfiguration )
+        public static BuildArguments ReadFromArtifactManifest( BuildContext context, BuildConfiguration buildConfiguration )
             => ArtifactManifestFile.CreateParametricStringArguments( context, buildConfiguration );
+
+        public static bool TryCreate( BuildContext context, BuildConfiguration configuration, [NotNullWhen( true )] out BuildArguments? buildArguments )
+        {
+            if ( !MainVersionFile.TryRead( context, out var mainVersionFile ) )
+            {
+                buildArguments = null;
+
+                return false;
+            }
+
+            if ( !AutoUpdatedVersionsFile.TryRead( context, out var packageVersion, out var packageMainVersion ) )
+            {
+                buildArguments = null;
+
+                return false;
+            }
+
+            buildArguments = new BuildArguments()
+            {
+                MSBuildConfiguration = context.Product.DependencyDefinition.MSBuildConfiguration[configuration],
+                Configuration = configuration.ToString(),
+                PackageVersion = packageVersion
+            };
+
+            return true;
+        }
     }
 }

src/PostSharp.Engineering.BuildTools/Build/Publishing/PublishCommand.cs

@@ -84,13 +84,8 @@ private static bool Execute( BuildContext context, PublishSettings settings )
             return false;
         }
 
-        if ( !MasterGenerator.TryWriteFiles( context, settings ) )
-        {
-            return false;
-        }
-
         // TODO: Verification is broken - NuGet verification is slow and makes the verification fail
-        // on seemimngly unpublished packages.
+        // on seemingly unpublished packages.
         // if ( settings.BuildConfiguration == BuildConfiguration.Public )
         // {
         //     if ( !product.Verify( context, settings ) )
@@ -100,7 +95,12 @@ private static bool Execute( BuildContext context, PublishSettings settings )
         // }
 
         var configuration = settings.BuildConfiguration;
-        var buildArguments = BuildArguments.Read( context, configuration );
+
+        if ( !BuildArguments.TryCreate( context, configuration, out var buildArguments ) )
+        {
+            return false;
+        }
+
         var directories = product.GetArtifactsAbsoluteDirectories( context, configuration );
         var configurationInfo = product.Configurations.GetValue( configuration );
         var hasTarget = false;

src/PostSharp.Engineering.BuildTools/Build/Swapping/SwapCommand.cs

@@ -26,7 +26,12 @@ private static bool Execute( BuildContext context, SwapSettings settings )
     {
         var product = context.Product;
         var configuration = product.Configurations.GetValue( settings.BuildConfiguration );
-        var buildArguments = BuildArguments.Read( context, settings.BuildConfiguration );
+
+        if ( !BuildArguments.TryCreate( context, settings.BuildConfiguration, out var buildArguments ) )
+        {
+            return false;
+        }
+
         var directories = product.GetArtifactsAbsoluteDirectories( context, settings.BuildConfiguration );
 
         var success = true;

src/PostSharp.Engineering.BuildTools/Build/Testing/TestCommand.cs

@@ -110,7 +110,7 @@ public static bool Execute( BuildContext context, BuildSettings settings )
         }
 
         // Raise the post-test event.
-        var buildInfo = BuildArguments.Read( context, settings.BuildConfiguration );
+        var buildInfo = BuildArguments.ReadFromArtifactManifest( context, settings.BuildConfiguration );
         var privateArtifactsDirectory = product.GetPrivateArtifactsAbsoluteDirectory( context, settings.BuildConfiguration );
         var publicArtifactsDirectory = product.GetPublicArtifactsAbsoluteDirectory( context );
 

src/PostSharp.Engineering.BuildTools/Tools/VerifyCommand.cs

@@ -20,7 +20,11 @@ public static bool Execute( BuildContext context, PublishSettings settings )
 
         if ( configuration == BuildConfiguration.Public )
         {
-            var buildArguments = BuildArguments.Read( context, configuration );
+            if ( !BuildArguments.TryCreate( context, configuration, out var buildArguments ) )
+            {
+                return false;
+            }
+
             var directories = product.GetArtifactsAbsoluteDirectories( context, configuration );
 
             // Verify that public packages have no private dependencies.