Revert "Change checkout directories and encapsulated artifact rules from string to object."

This reverts commit 90a865c

Author: gfraiteur

src/PostSharp.Engineering.BuildTools/Build/BuildConfigurationInfo.cs

@@ -2,7 +2,6 @@
 
 using PostSharp.Engineering.BuildTools.Build.Publishing;
 using PostSharp.Engineering.BuildTools.Build.Swapping;
-using PostSharp.Engineering.BuildTools.ContinuousIntegration.Model;
 using PostSharp.Engineering.BuildTools.ContinuousIntegration.Triggers;
 using System;
 
@@ -35,7 +34,7 @@ public record BuildConfigurationInfo(
     string? TeamCityDeploymentName = null,
     string? TeamCitySwapName = null,
     bool SwapAfterPublishing = false,
-    ArtifactRule[]? AdditionalArtifactRules = null,
+    string[]? AdditionalArtifactRules = null,
     bool ExportsToTeamCityBuild = true,
     bool ExportsToTeamCityDeploy = true,
     bool ExportsToTeamCityDeployWithoutDependencies = false,

src/PostSharp.Engineering.BuildTools/Build/Helpers/SourceDependenciesHelper.cs

@@ -17,7 +17,7 @@ internal static bool RestoreSourceDependencies( BuildContext context )
             return true;
         }
 
-        var sourceDependenciesDirectory = Path.Combine( context.RepoDirectory, product.SourceDependenciesDirectory );
+        var sourceDependenciesDirectory = Path.Combine( context.RepoDirectory, "source-dependencies" );
 
         if ( !Directory.Exists( sourceDependenciesDirectory ) )
         {

src/PostSharp.Engineering.BuildTools/Build/Model/Product.cs

@@ -6,7 +6,6 @@
 using PostSharp.Engineering.BuildTools.Build.Files;
 using PostSharp.Engineering.BuildTools.Build.Publishing;
 using PostSharp.Engineering.BuildTools.ContinuousIntegration.Model;
-using PostSharp.Engineering.BuildTools.ContinuousIntegration.TeamCity;
 using PostSharp.Engineering.BuildTools.ContinuousIntegration.Triggers;
 using PostSharp.Engineering.BuildTools.Dependencies.Model;
 using PostSharp.Engineering.BuildTools.Docker;
@@ -93,7 +92,7 @@ public string GetPrivateArtifactsRelativeDirectory( BuildConfiguration configura
 
         public string DumpDirectory { get; init; } = Path.Combine( "artifacts", "dumps" );
 
-        public string SourceDependenciesDirectory { get; init; } = "source-dependencies";
+        public string SourceDependenciesDirectory { get; init; } = Path.Combine( "source-dependencies" );
 
         public bool GenerateArcadeProperties { get; init; }
 
@@ -161,7 +160,7 @@ public TimeSpan BuildTimeout
                     ExportsToTeamCityDeploy: true,
                     RequiresUpstreamCheck: true ) );
 
-        public ArtifactRule[] DefaultArtifactRules { get; } = [];
+        public ImmutableArray<string> DefaultArtifactRules { get; } = ImmutableArray<string>.Empty;
 
         /// <summary>
         /// List of properties that must be exported into the *.version.props. These properties must be defined in *.props files specified as the dictionary keys.
@@ -285,7 +284,7 @@ public bool TryGetDependencyDefinition( string name, [NotNullWhen( true )] out D
         public ProductExtension[] Extensions { get; init; } = [];
 
         public bool BuildRequiresSourceDependencies { get; init; } = true;
-
+        
         internal string GetPrivateArtifactsAbsoluteDirectory( BuildContext context, BuildConfiguration configuration )
             => Path.Combine(
                 context.RepoDirectory,

src/PostSharp.Engineering.BuildTools/ContinuousIntegration/Model/ArtifactRule.cs

@@ -29,15 +29,14 @@ internal override TeamCityBuildConfiguration TeamCityBuildConfiguration( Product
             this.Name,
             this.Branch,
             productProperties.VcsId,
-            product.ProductName,
             product.ResolvedBuildAgentRequirements )
         {
             BuildSteps =
             [
                 new PowerShellBuildStep(
                     "Exec",
                     $"Execute {this.Script}",
-                    $"{product.ProductName}/{this.Script}",
+                    this.Script,
                     this.Arguments,
                     product.DockerSpec )
             ],

src/PostSharp.Engineering.BuildTools/ContinuousIntegration/Model/PowershellAdditionalCiBuildConfiguration.cs

@@ -8,15 +8,9 @@ namespace PostSharp.Engineering.BuildTools.ContinuousIntegration.TeamCity.BuildS
 
 internal class EngineeringBuildBuildStep : EngineeringCommandBuildStep
 {
-    public EngineeringBuildBuildStep(
-        BuildConfiguration configuration,
-        string checkoutDirectory,
-        bool testOnBuild,
-        DockerSpec? dockerSpec,
-        TimeSpan? timeout ) : base(
+    public EngineeringBuildBuildStep( BuildConfiguration configuration, bool testOnBuild, DockerSpec? dockerSpec, TimeSpan? timeout ) : base(
         "Build",
         "Build",
-        checkoutDirectory,
         testOnBuild ? "test" : "build",
         $"--configuration {configuration} --buildNumber %build.number% --buildType %system.teamcity.buildType.id%",
         true,

src/PostSharp.Engineering.BuildTools/ContinuousIntegration/TeamCity/BuildSteps/EngineeringBuildBuildStep.cs

@@ -18,15 +18,14 @@ internal class EngineeringCommandBuildStep : PowerShellBuildStep
     public EngineeringCommandBuildStep(
         string id,
         string name,
-        string checkoutDirectory,
         string command,
         string? arguments = null,
         bool areCustomArgumentsAllowed = false,
         DockerSpec? dockerSpec = null,
         TimeSpan? timeout = null ) : base(
         id,
         name,
-        $"{checkoutDirectory}/Build.ps1",
+        "Build.ps1",
         GetScriptArguments( id, command, arguments, areCustomArgumentsAllowed, timeout ),
         dockerSpec )
     {

src/PostSharp.Engineering.BuildTools/ContinuousIntegration/TeamCity/BuildSteps/EngineeringCommandBuildStep.cs

@@ -8,10 +8,9 @@ namespace PostSharp.Engineering.BuildTools.ContinuousIntegration.TeamCity.BuildS
 
 internal class EngineeringPublishBuildStep : EngineeringCommandBuildStep
 {
-    public EngineeringPublishBuildStep( BuildConfiguration configuration, string checkoutDirectory, DockerSpec? dockerSpec, TimeSpan? timeSpan ) : base(
+    public EngineeringPublishBuildStep( BuildConfiguration configuration, DockerSpec? dockerSpec, TimeSpan? timeSpan ) : base(
         "Publish",
         "Publish",
-        checkoutDirectory,
         "publish",
         $"--configuration {configuration}",
         true,

src/PostSharp.Engineering.BuildTools/ContinuousIntegration/TeamCity/BuildSteps/EngineeringPublishBuildStep.cs

@@ -3,7 +3,6 @@
 using PostSharp.Engineering.BuildTools.Build;
 using PostSharp.Engineering.BuildTools.Build.Files;
 using PostSharp.Engineering.BuildTools.Build.Model;
-using PostSharp.Engineering.BuildTools.ContinuousIntegration.Model;
 using System;
 using System.IO;
 using System.Linq;
@@ -38,11 +37,7 @@ public ConfigurationProperties( Product product, BuildConfiguration configuratio
             .Select( d => new TeamCitySnapshotDependency(
                          d.Definition.CiConfiguration.BuildTypes[d.Configuration],
                          true,
-                         [
-                             new ArtifactRule(
-                                 $"dependencies/{d.Definition.Name}",
-                                 d.Definition.GetPrivateArtifactsDirectory( d.Configuration ).Replace( Path.DirectorySeparatorChar, '/' ) )
-                         ] ) )
+                         $"+:{d.Definition.GetPrivateArtifactsDirectory( d.Configuration ).Replace( Path.DirectorySeparatorChar, '/' )}/**/*=>dependencies/{d.Definition.Name}" ) )
             .ToList();
 
         var sourceSnapshotDependencies = product.SourceDependencies.Where( d => d.GenerateSnapshotDependency )

src/PostSharp.Engineering.BuildTools/ContinuousIntegration/TeamCity/Generation/ConfigurationProperties.cs

@@ -45,7 +45,7 @@ public ProductProperties( Product product )
                                                                          d.CiConfiguration.ProjectId.ToString(),
                                                                          TeamCityHelper.GetVcsId( d ),
                                                                          true,
-                                                                         $"+:. => {d.Name}" ) )
+                                                                         $"+:. => {product.SourceDependenciesDirectory}/{d.Name}" ) )
             .ToArray();
     }
 }