fix(window): Refactor window size and position to use LogicalSize and LogicalPosition#1072
Open
9Ninety wants to merge 1 commit into
Open
fix(window): Refactor window size and position to use LogicalSize and LogicalPosition#10729Ninety wants to merge 1 commit into
9Ninety wants to merge 1 commit into
Conversation
… LogicalPosition This commit refactors the window size and position calculations in `src-tauri/src/window.rs` to use `LogicalSize` and `LogicalPosition` instead of `PhysicalSize` and `PhysicalPosition`. This change ensures that the window size and position are independent of the screen's DPI, leading to a more consistent user experience across different displays. The DPI scaling is now handled internally by Tauri.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: This commit ensures that Pot has the same size on monitors with different scale ratios. It no longer becomes progressively smaller on non-primary monitors with smaller scale ratios.
This commit refactors the window size and position calculations in
src-tauri/src/window.rsto useLogicalSizeandLogicalPositioninstead ofPhysicalSizeandPhysicalPosition.This change ensures that the window size and position are independent of the screen's DPI, leading to a more consistent user experience across different displays. The DPI scaling is now handled internally by Tauri.
Fix #962