Fix biastee settings to return actual device state#68
Open
aurimasniekis wants to merge 1 commit into
Open
Conversation
Replace the static `false` values for `biastee_rx` and `biastee_tx` with calls to `bladerf_get_bias_tee()` so readSetting() reflects the device's current configuration and reports errors from the driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the static
"false"return values forbiastee_txandbiastee_rxinreadSetting()with calls tobladerf_get_bias_tee().Changes
"true"or"false"based on the actual hardware statebladerf_get_bias_tee()failsWhy
Previously, these settings always returned
"false", regardless of theactual hardware configuration. This resulted in incorrect state reporting
to users and higher-level applications.
Impact
readSetting()with real device state