Dynamically set tx_streamer buffer size based on sample rate#74
Merged
Conversation
The original hardcoded buffer size of 4096 is too small for a full duplex RX and TX stream at higher sample rates, leading to dropped samples during transmit. Change tested with a duplex stream at 2 Msps.
Member
|
Looks ready to merge. Let others get a word in, otherwise we'll merge in a about 2 weeks. |
Contributor
Author
|
Can this be merged now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in #73 the hardcoded buffer size of 4096 for the tx_streamer seems inadequate for high-rate full-duplex streams. This change uses the same kind of tx_streamer buffer size adjustment code as for the rx_streamer.