fix(ci): harden prod Jenkins deployment pipelines#752
Merged
Conversation
Fix environment variable typos, remove hardcoded workspace paths, add preflight checks, and ensure rollback commands correctly interpolate namespace values. Made-with: Cursor
Contributor
WalkthroughThree production Jenkins pipelines were updated to fix branch-to-environment mappings, add early preflight checks for workspace/Dockerfile presence, change Docker build context to Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer/Branch
participant Jenkins as Jenkins Pipeline
participant FS as Workspace (env.WORKSPACE)
participant Docker as Docker Build
participant Registry as Image Registry
participant K8s as Kubernetes (kubectl)
Dev->>Jenkins: push (origin/main / origin/dir-restruct)
Jenkins->>Jenkins: Quality Gates (uv, ruff, tests)
Jenkins->>FS: Preflight Checks (workspace & Dockerfile)
alt preflight OK
Jenkins->>Docker: docker build context=${env.WORKSPACE}
Docker->>Registry: push image
Jenkins->>K8s: kubectl apply / rollout restart
else preflight fails
Jenkins->>Jenkins: fail pipeline early
end
Note over Jenkins,K8s: rollback uses interpolated "${params.namespace}"
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
deployment/prod/mom-api/Jenkinsfile_API_Prod (1)
50-59: Optional:test -d "${env.WORKSPACE}"is largely a no-op.Jenkins guarantees the workspace directory exists before any
shstep can run (the shell itself is launched withWORKSPACEascwd), so this assertion will essentially never fire. Thetest -fagainstapi.Dockerfileis the valuable check. If you want the preflight to catch real issues, consider also asserting on other files the build relies on (e.g. dependency manifests copied by the Dockerfile) so a partial/dirty workspace fails fast here rather than several minutes into the Docker build.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deployment/prod/mom-api/Jenkinsfile_API_Prod` around lines 50 - 59, The Preflight Checks stage currently runs a redundant test -d "${env.WORKSPACE}" and only verifies api.Dockerfile; remove the no-op workspace existence check and expand the check in the 'Preflight Checks' stage to assert presence of other build-critical files referenced by the Dockerfile (e.g., dependency manifests, package.json, go.mod, requirements.txt or any files copied in the Dockerfile) by replacing or augmenting the test -f "${env.WORKSPACE}/deployment/prod/mom-api/api.Dockerfile" line with additional test -f checks for those specific files so a missing/partial workspace fails fast before Docker build.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deployment/prod/convo-server/Jenkinsfile_Convo_Prod`:
- Around line 27-30: The Jenkinsfile currently permits branch == "origin/devops"
and sets env.ENVIRONMENT = 'devops' even though other prod pipelines
(Jenkinsfile_API_Prod, Jenkinsfile_CELERY_Prod) do not and env.ENVIRONMENT is
never used; remove the devops branch allowance to match the other prod pipelines
by deleting the else if (branch == "origin/devops") block and the corresponding
env.ENVIRONMENT assignment, leaving the error(...) fallback intact;
alternatively, if allowing devops was intentional, add the same branch check and
env.ENVIRONMENT handling to Jenkinsfile_API_Prod and Jenkinsfile_CELERY_Prod and
ensure downstream usage of env.ENVIRONMENT or document why prod deploy access
from origin/devops is required.
---
Nitpick comments:
In `@deployment/prod/mom-api/Jenkinsfile_API_Prod`:
- Around line 50-59: The Preflight Checks stage currently runs a redundant test
-d "${env.WORKSPACE}" and only verifies api.Dockerfile; remove the no-op
workspace existence check and expand the check in the 'Preflight Checks' stage
to assert presence of other build-critical files referenced by the Dockerfile
(e.g., dependency manifests, package.json, go.mod, requirements.txt or any files
copied in the Dockerfile) by replacing or augmenting the test -f
"${env.WORKSPACE}/deployment/prod/mom-api/api.Dockerfile" line with additional
test -f checks for those specific files so a missing/partial workspace fails
fast before Docker build.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: eaa589fc-e304-4a9e-bc88-5d0dae40b70a
📒 Files selected for processing (3)
deployment/prod/celery/Jenkinsfile_CELERY_Proddeployment/prod/convo-server/Jenkinsfile_Convo_Proddeployment/prod/mom-api/Jenkinsfile_API_Prod
Remove origin/devops branch allowance from convo prod Jenkinsfile to match prod branch policy used by API and Celery pipelines. Made-with: Cursor
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
deployment/prod/convo-server/Jenkinsfile_Convo_Prod (1)
50-59: Preflight stage is fine; consider trimming the redundant workspace check and adding a clearer failure message.
test -d "${env.WORKSPACE}"is effectively a tautology — Jenkins won't reach this step if the workspace doesn't exist. The meaningful check is the Dockerfile presence. With the current baretest -f, a failure surfaces only as a non‑zero exit code in the console; an explicit error message will make triage faster.♻️ Optional refinement
stage('Preflight Checks') { steps { script { - sh """ - test -d "${env.WORKSPACE}" - test -f "${env.WORKSPACE}/deployment/prod/convo-server/convo.Dockerfile" - """ + sh """ + set -eu + DOCKERFILE="${env.WORKSPACE}/deployment/prod/convo-server/convo.Dockerfile" + if [ ! -f "\$DOCKERFILE" ]; then + echo "Preflight failed: Dockerfile not found at \$DOCKERFILE" >&2 + exit 1 + fi + """ } } }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@deployment/prod/convo-server/Jenkinsfile_Convo_Prod` around lines 50 - 59, Remove the redundant workspace existence test in the Preflight Checks stage and replace the bare Dockerfile test with an explicit check that fails with a clear error message: inside the script block where sh is run (stage 'Preflight Checks' in Jenkinsfile_Convo_Prod), remove or omit the line testing "${env.WORKSPACE}" and change the Dockerfile check for "${env.WORKSPACE}/deployment/prod/convo-server/convo.Dockerfile" to a conditional that prints a descriptive error (e.g., "ERROR: convo.Dockerfile not found at <path>") and exits non‑zero so the failure is obvious in logs; keep the check focused on the file path and ensure messages reference convo.Dockerfile and env.WORKSPACE so it's easy to locate.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@deployment/prod/convo-server/Jenkinsfile_Convo_Prod`:
- Around line 50-59: Remove the redundant workspace existence test in the
Preflight Checks stage and replace the bare Dockerfile test with an explicit
check that fails with a clear error message: inside the script block where sh is
run (stage 'Preflight Checks' in Jenkinsfile_Convo_Prod), remove or omit the
line testing "${env.WORKSPACE}" and change the Dockerfile check for
"${env.WORKSPACE}/deployment/prod/convo-server/convo.Dockerfile" to a
conditional that prints a descriptive error (e.g., "ERROR: convo.Dockerfile not
found at <path>") and exits non‑zero so the failure is obvious in logs; keep the
check focused on the file path and ensure messages reference convo.Dockerfile
and env.WORKSPACE so it's easy to locate.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d3a1e5c5-db65-411e-8131-de8f8f318820
📒 Files selected for processing (1)
deployment/prod/convo-server/Jenkinsfile_Convo_Prod
Run dependency sync, ruff reporting, and unit/integration test gates before prod image builds across backend deployment pipelines. Made-with: Cursor
|
Collaborator
Author
|
CI/CD hardening update:
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@deployment/prod/mom-api/Jenkinsfile_API_Prod`:
- Line 155: The shell invocation using params.namespace in the sh call (sh
"kubectl rollout undo deployment/mom-api-deployment -n ${params.namespace}") is
vulnerable to command injection; add server-side validation/sanitization before
interpolation: validate params.namespace against a strict Kubernetes namespace
regex/whitelist (e.g. /^[a-z0-9]([-a-z0-9]*[a-z0-9])?$/), fail the build or set
a safe default if it doesn't match, assign the validated value to a local
variable (e.g., validatedNamespace) and use that variable in the sh invocation
instead of raw params.namespace to ensure only safe namespace names are passed
to kubectl.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0fc37e4a-99c6-4eac-bf54-c6701b8d8d55
📒 Files selected for processing (3)
deployment/prod/celery/Jenkinsfile_CELERY_Proddeployment/prod/convo-server/Jenkinsfile_Convo_Proddeployment/prod/mom-api/Jenkinsfile_API_Prod
🚧 Files skipped from review as they are similar to previous changes (2)
- deployment/prod/celery/Jenkinsfile_CELERY_Prod
- deployment/prod/convo-server/Jenkinsfile_Convo_Prod
jdyaberi-pp
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix environment variable typos, remove hardcoded workspace paths, add preflight checks, and ensure rollback commands correctly interpolate namespace values.
Summary by CodeRabbit
Bug Fixes
Chores
Tests