feat(storage): Deinitialize modules before destruction

Call storage module deinitialization from the destroy path so modules
always leave the initialized state before their backend-specific
destruction runs.

Author: gfieni

src/sensor.c

@@ -283,9 +283,6 @@ main(int argc, char **argv)
         zclock_sleep((int)config->sensor.cgroup_discovery_interval_ms);
     }
 
-    /* clean storage module ressources */
-    storage_module_deinitialize(storage);
-
     ret = 0;
 
 cleanup:

src/storage.c

@@ -98,6 +98,7 @@ storage_module_destroy(struct storage_module *module)
     if (!module)
         return;
 
+    (*module->deinitialize)(module);
     (*module->destroy)(module);
     free(module);
 }

src/storage_mongodb.c

@@ -201,12 +201,12 @@ mongodb_store_report(struct storage_module *module, struct payload *payload)
 }
 
 static int
-mongodb_deinitialize(struct storage_module *module __attribute__ ((unused)))
+mongodb_deinitialize(struct storage_module *module)
 {
     struct mongodb_context *ctx = (struct mongodb_context *) module->context;
 
     if (!module->is_initialized)
-        return -1;
+        return 0;
 
     mongoc_collection_destroy(ctx->collection);
     mongoc_client_destroy(ctx->client);

src/storage_socket.c

@@ -307,11 +307,12 @@ socket_deinitialize(struct storage_module *module)
     struct socket_context *ctx = (struct socket_context *) module->context;
 
     if (!module->is_initialized)
-        return -1;
+        return 0;
 
     if (ctx->socket_fd != -1)
         close(ctx->socket_fd);
 
+    module->is_initialized = false;
     return 0;
 }